src: make ELDHistogram a HandleWrap #29317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s.
jasnell
approved these changes
Aug 26, 2019
LGTM. Something to keep in mind is I'm planning to abstract out the base histogram object wrapper implementation so it can be reused in more contexts (such as QUIC)
|
Landed in 0af62aa |
Trott
added a commit
that referenced
this issue
Sep 8, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: #29317 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this issue
Sep 20, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: #29317 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
to addaleax/node
that referenced
this issue
Sep 21, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs#29317
3 tasks
Merged
BridgeAR
added a commit
that referenced
this issue
Sep 25, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: #29317 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
to nodejs/quic
that referenced
this issue
Sep 29, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: nodejs/node#29317 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
to nodejs/quic
that referenced
this issue
Sep 29, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
added a commit
to nodejs/quic
that referenced
this issue
Oct 1, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: nodejs/node#29317 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
added a commit
to nodejs/quic
that referenced
this issue
Oct 1, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
added a commit
to nodejs/quic
that referenced
this issue
Oct 2, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: nodejs/node#29317 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
to nodejs/quic
that referenced
this issue
Oct 2, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
added a commit
to nodejs/quic
that referenced
this issue
Oct 2, 2019
This simplifies the implementation of ELDHistogram a bit, and more generally allows us to have weak JS references associated with `HandleWrap`s. PR-URL: nodejs/node#29317 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
added a commit
to nodejs/quic
that referenced
this issue
Oct 2, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This simplifies the implementation of ELDHistogram a bit,
and more generally allows us to have weak JS references
associated with
HandleWraps.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes