Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring: improve performance #29306

Merged
merged 0 commits into from Aug 28, 2019
Merged

querystring: improve performance #29306

merged 0 commits into from Aug 28, 2019

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Aug 25, 2019

Results:

                                                                   confidence improvement accuracy (*)     (**)    (***)
 querystring/querystring-parse.js n=1000000 type='altspaces'             ***    985.03 %      ±27.88%  ±40.04%  ±58.85%
 querystring/querystring-parse.js n=1000000 type='encodefake'            ***   1253.69 %      ±26.56%  ±38.14%  ±56.07%
 querystring/querystring-parse.js n=1000000 type='encodelast'            ***   1012.30 %      ±26.81%  ±38.49%  ±56.56%
 querystring/querystring-parse.js n=1000000 type='encodemany'            ***    712.02 %      ±34.90%  ±50.11%  ±73.65%
 querystring/querystring-parse.js n=1000000 type='manypairs'             ***      4.42 %       ±1.35%   ±1.85%   ±2.52%
 querystring/querystring-parse.js n=1000000 type='multicharsep'          ***   1053.69 %      ±21.01%  ±30.15%  ±44.28%
 querystring/querystring-parse.js n=1000000 type='multivalue'            ***   1161.95 %      ±41.03%  ±58.93%  ±86.66%
 querystring/querystring-parse.js n=1000000 type='noencode'              ***   1094.45 %      ±96.37% ±138.44% ±203.66%

 querystring/querystring-stringify.js n=1000000 type='array'             ***      8.28 %       ±2.20%   ±2.94%   ±3.84%
 querystring/querystring-stringify.js n=1000000 type='noencode'           **      3.38 %       ±2.43%   ±3.24%   ±4.21%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mscdex mscdex added querystring performance labels Aug 25, 2019
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Aug 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25224/

@mscdex
Copy link
Contributor Author

@mscdex mscdex commented Aug 25, 2019

I believe this may be applicable to v10.x as well (in addition to v12.x of course), but I have not yet tested.

addaleax
addaleax approved these changes Aug 25, 2019
View changes
Copy link
Member

@addaleax addaleax left a comment

Do you know why the perf difference is so large? It doesn’t look like there are any substantial changes to the code itself, which makes me curious…

bnoordhuis
bnoordhuis approved these changes Aug 25, 2019
View changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

I'm also curious. I would expect preallocating the charCodes() array to be 2-3x faster but that only explains the multicharsep benchmark and that still doesn't explain the 10x speedup. :-)

Nice work at any rate!

@mscdex
Copy link
Contributor Author

@mscdex mscdex commented Aug 25, 2019 •
edited

I didn't dig that deep to find out why but I think V8 is not optimizing the parse() function? I also noticed that node v8.x is ~5x faster or so than node v10.x+ when it comes to parse() (without these changes).

@ZYSzys ZYSzys added the author ready label Aug 26, 2019
wa-Nadoo
wa-Nadoo reviewed Aug 26, 2019
View changes
lib/querystring.js Outdated Show resolved Hide resolved
@mscdex mscdex closed this Aug 28, 2019
@mscdex mscdex merged commit 248e9ec into nodejs:master Aug 28, 2019
1 check passed
@mscdex mscdex deleted the querystring-perf branch Aug 28, 2019
BridgeAR pushed a commit that referenced this issue Sep 3, 2019
@mscdex @BridgeAR
querystring: improve performance
1223795 
PR-URL: #29306
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this issue Sep 4, 2019
@mscdex @BridgeAR
querystring: improve performance
0e1ccca 
PR-URL: #29306
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa-Nadoo wa-Nadoo

@bnoordhuis bnoordhuis

@jasnell jasnell

@addaleax addaleax

@lpinca lpinca

@trivikr trivikr

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready performance querystring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mscdex @nodejs-github-bot @bnoordhuis @jasnell @addaleax @wa-Nadoo @lpinca @trivikr @ZYSzys