http: reset parser.incoming when server request is finished #29297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: nodejs#28646 Refs: nodejs#29263 Fixes: nodejs#9668
lpinca
approved these changes
Aug 24, 2019
|
Looks like the test fails on Windows sometimes. I’ll look into that, but if I don’t figure out what’s going on, I’d probably just add a skip() call to it. |
mscdex
reviewed
Aug 24, 2019
ronag
approved these changes
Aug 24, 2019
|
@mcollina I’ve pushed a commit to skip the test on Windows as suggested above. I’ll still investigate why, but this way this PR should be able to get into v12.9.1. |
addaleax
added
the
author ready
|
Can we please fast-track? Otherwise it won't be in 12.9.1. |
|
Please |
|
Landed in 6ab2848 |
addaleax
added a commit
that referenced
this issue
Aug 26, 2019
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: #28646 Refs: #29263 Fixes: #9668 PR-URL: #29297 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this issue
Aug 26, 2019
This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d did by waiting for the incoming request to be finished before releasing the `parser.incoming` object. Refs: #28646 Refs: #29263 Fixes: #9668 PR-URL: #29297 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This resolves a memory leak for keep-alive connections and does not
regress in the way that 779a05d did by waiting for
the incoming request to be finished before releasing the
parser.incomingobject.Refs: #28646
Refs: #29263
Fixes: #9668
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes