gyp: rm semicolons (Python != JavaScript) #29228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Aug 20, 2019
BridgeAR
approved these changes
Aug 20, 2019
richardlau
approved these changes
Aug 20, 2019
|
I'm going to assume that test failure wasn't my doing? |
Trott
approved these changes
Aug 20, 2019
trivikr
approved these changes
Aug 20, 2019
lpinca
approved these changes
Aug 20, 2019
rvagg
approved these changes
Aug 20, 2019
gengjiawen
approved these changes
Aug 23, 2019
|
Landed in 6726f56 |
Trott
added a commit
that referenced
this issue
Aug 23, 2019
PR-URL: #29228 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BridgeAR
added a commit
that referenced
this issue
Sep 3, 2019
PR-URL: #29228 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist
This is a follow-up PR from nodejs/node-gyp#1858 where these changes have been landed upstream (as well as follow-on from #29120).
There are some additional changes not in the upstream PR as it seems the node copy of gyp isn't identical.