Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add required settings to test-benchmark-buffer #29163
Conversation
Trott
added
the
fast-track
label
Aug 16, 2019
nodejs-github-bot
added
the
test
label
Aug 16, 2019
cjihrig
approved these changes
Aug 16, 2019
This comment has been minimized.
This comment has been minimized.
|
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3834/ Benchmark Test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8565/ Benchmark tests do not get run in regular CI, so a full regular CI run should not be necessary. |
ZYSzys
approved these changes
Aug 16, 2019
ZYSzys
approved these changes
Aug 16, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in b9ff6a3 |
Trott
closed this
Aug 16, 2019
Trott
force-pushed the
Trott:fix-buffer-benchmark-test
branch
from
b997840
to
b9ff6a3
Aug 16, 2019
Trott
merged commit b9ff6a3
into
nodejs:master
Aug 16, 2019
1 check passed
targos
added a commit
that referenced
this pull request
Aug 19, 2019
targos
added a commit
that referenced
this pull request
Aug 19, 2019
This was referenced Aug 20, 2019
JeniaBR
added a commit
to JeniaBR/node
that referenced
this pull request
Sep 11, 2019
JeniaBR
added a commit
to JeniaBR/node
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Trott commentedAug 16, 2019
A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.
node-daily-masteron CI will be broken until this lands.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes