Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline: support closing dumb terminals #29149

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Aug 15, 2019

Fixes: #29111

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline label Aug 15, 2019

@bnoordhuis
bnoordhuis approved these changes Aug 15, 2019
View changes
Copy link
Member

left a comment

Would be nice to test ^C as well but LGTM either way.
@jasnell
jasnell approved these changes Aug 16, 2019
View changes
@lpinca
lpinca approved these changes Aug 16, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25053/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 17, 2019 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/25054/

EDIT: CI was green.

@cjihrig cjihrig added the author ready label Aug 17, 2019

cjihrig added 2 commits Aug 15, 2019
@cjihrig
readline: close dumb terminals on Control+C 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
a5edcee
@cjihrig
readline: close dumb terminals on Control+D 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
93b341e

@cjihrig cjihrig force-pushed the cjihrig:dumb branch from a68b133 to 93b341e Aug 17, 2019

@cjihrig cjihrig merged commit 93b341e into nodejs:master Aug 17, 2019
1 of 3 checks passed

1 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Pull Request Build Created
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:dumb branch Aug 17, 2019

targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
readline: close dumb terminals on Control+C 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
81d3142
targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
readline: close dumb terminals on Control+D 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
59f6ff5
targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
readline: close dumb terminals on Control+C 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
3c346b8
targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
readline: close dumb terminals on Control+D 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: #29149
Fixes: #29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
7f11c72
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
readline: close dumb terminals on Control+C 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: nodejs#29149
Fixes: nodejs#29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
f72b66c
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
readline: close dumb terminals on Control+D 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: nodejs#29149
Fixes: nodejs#29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1720da0
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
readline: close dumb terminals on Control+C 
This commit adds support for closing a readline interface
on Control+C when the terminal is dumb.

PR-URL: nodejs#29149
Fixes: nodejs#29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2665ad5
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
readline: close dumb terminals on Control+D 
This commit adds support for closing a readline interface
on Control+D when the terminal is dumb.

PR-URL: nodejs#29149
Fixes: nodejs#29111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
3434185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@lpinca lpinca

Assignees
No one assigned
Labels
author ready readline
Projects
None yet
Milestone
No milestone
5 participants
@cjihrig @nodejs-github-bot @bnoordhuis @jasnell @lpinca
You can’t perform that action at this time.