Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick e3d7f8a #29105

Closed
wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

commented Aug 13, 2019

Python 2: dict.keys() is a list.
Python 3: dist.keys() is an iterator.
These changes support both Python 2 and Python 3.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added post-mortem V8 Engine labels Aug 13, 2019

@cclauss cclauss added the python label Aug 13, 2019

@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 13, 2019

I think these changes should be upstreamed to V8 first.
@cclauss

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 13, 2019

@cjihrig Sorry but I respectfully disagree. These are blocking changes to our progress. The v8 process just takes too long (proof: #24512) and we only have 141 days until Py2 EOL. The folks responsible for v8 do not want to see this transition succeed. If someone else has the patience to upstream these (minuscule) changes in parallel or after, they are invited to do so.
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 13, 2019

I opened https://chromium-review.googlesource.com/c/v8/v8/+/1751331 upstream.
@cclauss cclauss referenced this pull request Aug 13, 2019
Closed
1 of 4 tasks complete
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24966/
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 13, 2019

Floating patches on v8 increase maintenance burden. Lets give some time for @targos' upstream PR to land (or not land :-( if that is the unfortunate case) before floating a patch.

@cclauss cclauss requested review from sam-github and refack Aug 13, 2019

@MattIPv4
MattIPv4 reviewed Aug 14, 2019
View changes
Copy link
Contributor

left a comment

As we're updating this file, why not also drop the semi-colons?
@MattIPv4 MattIPv4 referenced this pull request Aug 14, 2019
Closed
1 of 1 task complete
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
ce33ffb

@targos targos force-pushed the cclauss:Py3_gen-postmortem-metadata.py branch from 06ff12a to ce33ffb Aug 14, 2019

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 14, 2019

The upstream commit landed. I updated this PR to cherry-pick it.
@cjihrig
cjihrig approved these changes Aug 14, 2019
View changes
@cclauss cclauss referenced this pull request Aug 14, 2019
Open
29 of 41 tasks complete
@sam-github
sam-github approved these changes Aug 14, 2019
View changes
@sam-github
sam-github approved these changes Aug 15, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 15, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25007/

@Trott Trott changed the title v8: py3 gen-postmortem-metadata.py deps: V8: cherry-pick e3d7f8a Aug 16, 2019

@Trott
Trott approved these changes Aug 16, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 16, 2019

Landed in 1173199

@Trott Trott closed this Aug 16, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 16, 2019
@cclauss @Trott
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
1173199

@cclauss cclauss deleted the cclauss:Py3_gen-postmortem-metadata.py branch Aug 16, 2019

targos added a commit to targos/node that referenced this pull request Aug 16, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
42b5c6f
targos added a commit to targos/node that referenced this pull request Aug 19, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
02132d0
targos added a commit to targos/node that referenced this pull request Aug 19, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
4787528

@targos targos added the dont-land-on-v12.x label Aug 19, 2019

targos added a commit that referenced this pull request Aug 19, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: #29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
1c7b0b4
targos added a commit that referenced this pull request Aug 19, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: #29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
a17d398
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
targos added a commit to targos/node that referenced this pull request Aug 21, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
b1dfd0a
targos added a commit to targos/node that referenced this pull request Aug 28, 2019
@cclauss @targos
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
f0fa11e
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cclauss @JeniaBR
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
48ae609
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cclauss @JeniaBR
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
a9f1c89
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cclauss @JeniaBR
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
9d94bbe
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cclauss @JeniaBR
deps: V8: cherry-pick e3d7f8a 
Original commit message:

    [build] update gen-postmortem-metadata for Python 3

    This change makes the code compatible with both Python 2 and Python 3.

    Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63207}

Refs: v8/v8@e3d7f8a

PR-URL: nodejs#29105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
b4e25dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4

@sam-github sam-github

@Trott Trott

@cjihrig cjihrig

@refack refack

Assignees
No one assigned
Labels
V8 Engine dont-land-on-v12.x post-mortem python
Projects
None yet
Milestone
No milestone
7 participants
@cclauss @cjihrig @targos @nodejs-github-bot @sam-github @Trott @MattIPv4
You can’t perform that action at this time.