Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add a testclean target #29094

Closed
wants to merge 2 commits into from
+15 −3

Conversation

@danbev
Copy link
Member

commented Aug 12, 2019

This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the clean target.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev
build: add a testclean target 
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.
Loading status checks…
a3f291d

@nodejs-github-bot nodejs-github-bot added the build label Aug 12, 2019

@Trott
Trott reviewed Aug 12, 2019
View changes
Copy link
Member

left a comment

Can you add this to vcbuild.bat too?
@addaleax
addaleax approved these changes Aug 12, 2019
View changes
@jasnell
jasnell approved these changes Aug 13, 2019
View changes
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 14, 2019

Can you add this to vcbuild.bat too?

I'll take a look at adding this to vcbuild.bat today. Thanks
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 14, 2019

Can you add this to vcbuild.bat too?

I'll take a look at adding this to vcbuild.bat today. Thanks

Looks like vcbuild.bat never cleans tmp directories, even if vcbuild.bat clean is called, so this would be adding new additional functionality to vcbuild.bat beyond what is being added to Makefile here. I'm not even sure that we put the tmp directories in the same place on Windows as we do on POSIX. I'm OK leaving this off. Someone can implement it later if it's desirable to have on Windows too.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 14, 2019

I'm not even sure that we put the tmp directories in the same place on Windows as we do on POSIX.

(We do.)
@danbev
squash: add testclean to vcbuild.bat
Loading status checks…
ea275a1
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 16, 2019

@Trott I've added a testclean target which can be called using:

danbev@win2 MINGW64 ~/node (master)
$ ./vcbuild.bat testclean
deleting test/.tmp*

Sorry this took so long, I had to set up a windows vm on azure as I had deleted my local window vm due to resource constraints.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25025/
@Trott
Trott approved these changes Aug 16, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25033/
Trott added a commit that referenced this pull request Aug 16, 2019
@danbev @Trott
build: add a testclean target 
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: #29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Loading status checks…
a890771
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 16, 2019

Landed in a890771

@Trott Trott closed this Aug 16, 2019

targos added a commit that referenced this pull request Aug 19, 2019
@danbev @targos
build: add a testclean target 
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: #29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
13ef5cf
targos added a commit that referenced this pull request Aug 19, 2019
@danbev @targos
build: add a testclean target 
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: #29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e51f924
@targos targos referenced this pull request Aug 19, 2019
Merged

@danbev danbev deleted the danbev:build-add-testclean-target branch Aug 20, 2019

This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@danbev @JeniaBR
build: add a testclean target 
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: nodejs#29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
5990a14
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@danbev @JeniaBR
build: add a testclean target 
This commit adds a target named testclean to allow for cleaning the
temporary files generated during a test run without having to use the
clean target.

PR-URL: nodejs#29094
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
83354bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@addaleax addaleax

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
5 participants
@danbev @Trott @nodejs-github-bot @jasnell @addaleax
You can’t perform that action at this time.