stream: writableEnded #28934

ronag · Aug 2, 2019

This is work towards resolving the response.finished confusion and future deprecation.

Note that implementation wise streams have both an ending and ended state. However, in this case (in order to avoid confusion in user space) writableEnded is equal to writable.ending. The ending vs ended situation is internal state required for internal stream logic.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

ronag · Aug 2, 2019

ping @mcollina @benjamingr

mcollina · Aug 2, 2019

Could you add some text that shows the relation between this and writableFinished?

Good work!

ronag · Aug 2, 2019

@mcollina Updated

mcollina · 2019-08-02T07:15:18Z

mcollina approved these changes

Aug 2, 2019

View changes

LGTM

vsemozhetbyt · 2019-08-02T16:09:34Z

vsemozhetbyt reviewed

Aug 2, 2019

View changes

Some doc nits.

doc/api/stream.md

doc/api/http2.md

doc/api/http.md

trivikr · 2019-08-02T19:23:19Z

trivikr requested changes

Aug 2, 2019

View changes

doc/api/http2.md

trivikr · 2019-08-02T19:40:30Z

trivikr approved these changes

Aug 2, 2019

View changes

nodejs-github-bot · Aug 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24835/

benjamingr · 2019-08-03T15:27:56Z

benjamingr approved these changes

Aug 3, 2019

View changes

mcollina · Aug 3, 2019

Would you mind rebase on top of master?


      stream: writableEnded

ronag · Aug 3, 2019

done

btw, what's up with the defineProperty configs that seem to be a bit all over?

Trott · Aug 17, 2019

A request: Your PR descriptions are usually very good, but your commit messages are usually very terse. I invariably end up amending the commit message using a bunch of stuff from the PR description. If you could be descriptive in the commit messages (or at least the first commit message--subsequent fixup commits get squashed away anyway), that would make landing a little bit easier. If you have a good reason why your commit messages are terse, that's fine, I can keep updating the commit messages upon landing. But if it's all the same to you, more info in the commit messages please! (Putting this publicly because you're not the only person for whom this is true so maybe others will see it and respond accordingly. Not trying to shame anyone or anything. I've certainly had more than my own share of commit messages that didn't even contain a verb.)

Trott · 2019-08-17T06:13:44Z

Trott approved these changes

Aug 17, 2019

View changes

LGTM if CI passes.

ronag · Aug 17, 2019

A request:

... I have no reason other than that's how I'm used to do it :). I'll try to improve in future PR's & commits.

nodejs-github-bot · Aug 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25045/

Trott · Aug 17, 2019

Landed in 6f613d8


      http,stream: add writableEnded

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: #28934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>


      http,stream: add writableEnded

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: #28934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* **crypto**:
  * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding (Tobias Nießen) [#28335](#28335).
* **deps**:
  * Updated V8 to 7.6.303.29 (Michaël Zasso) [#28955](#28955).
    * Improves the performance of various APIs such as `JSON.parse` and methods
      called on frozen arrays.
    * Adds the [`Promise.allSettled`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled) method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0 (cjihrig) [#29070](#29070).
    * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added.
* **fs**:
  * Added `fs.writev` and `fs.writevSync` methods. They allow to write an array of `ArrayBufferView`s to a file descriptor (Anas Aboureada) [#25925](#25925).
* **http**:
  * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` [#29018](#29018).
* **stream**:
  * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. (Robert Nagy) [#28934](#28934).

PR-URL: #29209


      http,stream: add writableEnded

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: #28934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* **crypto**:
  * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding (Tobias Nießen) [#28335](#28335).
* **deps**:
  * Updated V8 to 7.6.303.29 (Michaël Zasso) [#28955](#28955).
    * Improves the performance of various APIs such as `JSON.parse` and methods
      called on frozen arrays.
    * Adds the [`Promise.allSettled`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled) method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0 (cjihrig) [#29070](#29070).
    * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added.
* **fs**:
  * Added `fs.writev` and `fs.writevSync` methods. They allow to write an array of `ArrayBufferView`s to a file descriptor (Anas Aboureada) [#25925](#25925).
* **http**:
  * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` [#29018](#29018).
* **stream**:
  * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. (Robert Nagy) [#28934](#28934).

PR-URL: #29209


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* **crypto**:
  * Added an oaepHash option to asymmetric encryption which allows users to specify a hash function when using OAEP padding (Tobias Nießen) [#28335](#28335).
* **deps**:
  * Updated V8 to 7.6.303.29 (Michaël Zasso) [#28955](#28955).
    * Improves the performance of various APIs such as `JSON.parse` and methods
      called on frozen arrays.
    * Adds the [`Promise.allSettled`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled) method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0 (cjihrig) [#29070](#29070).
    * `UV_FS_O_FILEMAP` has been added for faster access to memory mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been added.
* **fs**:
  * Added `fs.writev` and `fs.writevSync` methods. They allow to write an array of `ArrayBufferView`s to a file descriptor (Anas Aboureada) [#25925](#25925).
* **http**:
  * Added three properties to `OutgoingMessage.prototype`: `writableObjectMode`, `writableLength` and `writableHighWaterMark` [#29018](#29018).
* **stream**:
  * Added an new property `writableEnded` to writable streams. Its value is set to `true` after `writable.end()` has been called. (Robert Nagy) [#28934](#28934).

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    https://github.com/nodejs/node/pull/29186/files
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    https://github.com/nodejs/node/pull/29186/files
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    https://github.com/nodejs/node/pull/29186/files
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    #29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    #28335
* deps:
  * Updated V8 to 7.6.303.29. #28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. #29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. #25925
    #29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    #29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    #28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    #28934

PR-URL: #29210


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    nodejs#29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210


      http,stream: add writableEnded

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: nodejs#28934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    nodejs#29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210


      http,stream: add writableEnded

This is work towards resolving the response.finished confusion and
future deprecation.

Note that implementation-wise, streams have both an ending and ended
state. However, in this case (in order to avoid confusion in user space)
writableEnded is equal to writable.ending. The ending vs ended situation
is internal state required for internal stream logic.

PR-URL: nodejs#28934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>


      2019-08-20, Version 12.9.0 (Current)

Notable changes:

* crypto:
  * Added an oaepHash option to asymmetric encryption which allows
    users to specify a hash function when using OAEP padding.
    nodejs#28335
* deps:
  * Updated V8 to 7.6.303.29. nodejs#28955
    * Improves the performance of various APIs such as `JSON.parse` and
      methods called on frozen arrays.
    * Adds the Promise.allSettled method.
    * Improves support of `BigInt` in `Intl` methods.
    * For more information: https://v8.dev/blog/v8-release-76
  * Updated libuv to 1.31.0. nodejs#29070
    * `UV_FS_O_FILEMAP` has been added for faster access to memory
      mapped files on Windows.
    * `uv_fs_mkdir()` now returns `UV_EINVAL` for invalid filenames on
      Windows. It previously returned `UV_ENOENT`.
    * The `uv_fs_statfs()` API has been added.
    * The `uv_os_environ()` and `uv_os_free_environ()` APIs have been
      added.
* fs:
  * Added `fs.writev`, `fs.writevSync` and `filehandle.writev` (promise
    version) methods. They allow to write an array of `ArrayBufferView`s
    to a file descriptor. nodejs#25925
    nodejs#29186
* http:
  * Added three properties to `OutgoingMessage.prototype`:
    `writableObjectMode`, `writableLength` and `writableHighWaterMark`
    nodejs#29018
* stream:
  * Added an new property `readableEnded` to readable streams. Its value
    is set to `true` when the `'end'` event is emitted.
    nodejs#28814
  * Added an new property `writableEnded` to writable streams. Its value
    is set to `true` after `writable.end()` has been called.
    nodejs#28934

PR-URL: nodejs#29210

nodejs-github-bot added http http2 stream labels Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from f07dd71 to b5047fa Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from 9781b2e to 2acbd15 Aug 2, 2019

ronag referenced this pull request Aug 2, 2019

doc: deprecate finished #28679

Open

4 of 4 tasks complete

ronag changed the title ~~Stream writable ended~~ stream: writableEnded Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from 2acbd15 to d4dfee9 Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from a6b8aa1 to 80afc1e Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from 7c29569 to 6ab4ad4 Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from 2ad49f1 to 3c8930d Aug 3, 2019

stream: writableEnded

e42af56

ronag force-pushed the nxtedition:stream-writableEnded branch from 3c8930d to 9dd1575 Aug 3, 2019

Trott added the author ready label Aug 17, 2019

Trott closed this Aug 17, 2019

Trott added a commit that referenced this pull request Aug 17, 2019

targos added a commit that referenced this pull request Aug 19, 2019

targos referenced this pull request Aug 19, 2019

v12.9.0 release proposal #29210

Merged

targos added a commit that referenced this pull request Aug 19, 2019

targos added a commit that referenced this pull request Aug 20, 2019

targos added a commit to targos/node that referenced this pull request Aug 20, 2019

targos added a commit that referenced this pull request Aug 20, 2019

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2019

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019

nodejs/node

stream: writableEnded #28934

stream: writableEnded #28934

ronag commented Aug 2, 2019 •

edited

nodejs-github-bot added http http2 stream labels Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from `f07dd71` to `b5047fa` Aug 2, 2019

This comment has been minimized.

ronag commented Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from `9781b2e` to `2acbd15` Aug 2, 2019

ronag changed the title Stream writable ended stream: writableEnded Aug 2, 2019

This comment has been minimized.

mcollina commented Aug 2, 2019 •

edited

This comment has been minimized.

ronag commented Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from `2acbd15` to `d4dfee9` Aug 2, 2019

mcollina left a comment

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from `a6b8aa1` to `80afc1e` Aug 2, 2019

vsemozhetbyt left a comment

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from `7c29569` to `6ab4ad4` Aug 2, 2019

This comment has been minimized.

nodejs-github-bot commented Aug 3, 2019

This comment has been minimized.

mcollina commented Aug 3, 2019 •

edited

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from `2ad49f1` to `3c8930d` Aug 3, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from `3c8930d` to `9dd1575` Aug 3, 2019

This comment has been minimized.

ronag commented Aug 3, 2019

Trott added the author ready label Aug 17, 2019

This comment has been minimized.

Trott commented Aug 17, 2019

Trott left a comment

This comment has been minimized.

ronag commented Aug 17, 2019

This comment has been minimized.

nodejs-github-bot commented Aug 17, 2019

This comment has been minimized.

Trott commented Aug 17, 2019

Trott closed this Aug 17, 2019

nodejs/node

Join GitHub today

stream: writableEnded #28934

Conversation

ronag commented Aug 2, 2019 • edited

Checklist

nodejs-github-bot added http http2 stream labels Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from f07dd71 to b5047fa Aug 2, 2019

This comment has been minimized.

ronag commented Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from 9781b2e to 2acbd15 Aug 2, 2019

ronag changed the title Stream writable ended stream: writableEnded Aug 2, 2019

This comment has been minimized.

mcollina commented Aug 2, 2019 • edited

This comment has been minimized.

ronag commented Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from 2acbd15 to d4dfee9 Aug 2, 2019

mcollina left a comment

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from a6b8aa1 to 80afc1e Aug 2, 2019

vsemozhetbyt left a comment

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from 7c29569 to 6ab4ad4 Aug 2, 2019

This comment has been minimized.

nodejs-github-bot commented Aug 3, 2019

This comment has been minimized.

mcollina commented Aug 3, 2019 • edited

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from 2ad49f1 to 3c8930d Aug 3, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from 3c8930d to 9dd1575 Aug 3, 2019

This comment has been minimized.

ronag commented Aug 3, 2019

Trott added the author ready label Aug 17, 2019

This comment has been minimized.

Trott commented Aug 17, 2019

Trott left a comment

This comment has been minimized.

ronag commented Aug 17, 2019

This comment has been minimized.

nodejs-github-bot commented Aug 17, 2019

This comment has been minimized.

Trott commented Aug 17, 2019

Trott closed this Aug 17, 2019

ronag commented Aug 2, 2019 •

edited

ronag force-pushed the nxtedition:stream-writableEnded branch from `f07dd71` to `b5047fa` Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from `9781b2e` to `2acbd15` Aug 2, 2019

mcollina commented Aug 2, 2019 •

edited

ronag force-pushed the nxtedition:stream-writableEnded branch from `2acbd15` to `d4dfee9` Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from `a6b8aa1` to `80afc1e` Aug 2, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch 2 times, most recently from `7c29569` to `6ab4ad4` Aug 2, 2019

mcollina commented Aug 3, 2019 •

edited

ronag force-pushed the nxtedition:stream-writableEnded branch 3 times, most recently from `2ad49f1` to `3c8930d` Aug 3, 2019

ronag force-pushed the nxtedition:stream-writableEnded branch from `3c8930d` to `9dd1575` Aug 3, 2019