Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] Update openssl 1.0.2s #28230

Closed
wants to merge 6 commits into from

Conversation

@sam-github
Copy link
Member

sam-github commented Jun 14, 2019

See nodejs/Release#448

I am still building locally, it will be a while, maybe CI is faster.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Jun 14, 2019 •
edited

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23887/
CI: https://ci.nodejs.org/job/node-test-pull-request/23889/
@sam-github sam-github force-pushed the sam-github:update-openssl-1.0.2s-v8.x branch from 0884ff4 to 0a37768 Jun 14, 2019
@sam-github sam-github changed the title [v8.x] Update openssl 1.1.1c [v8.x] Update openssl 1.0.2s Jun 14, 2019
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member Author

sam-github commented Jun 14, 2019

There was a problem with how I upgraded, I messed up the opensslconf.h files, its now fixed.

Also, the subject was wrong, sorry. This is NOT upgrading to openssl 1.1.1 (that would be totally incompatible), its just upgrading from openssl 1.0.2r to 1.0.2s. That this matches my initials is coincidental.
@joyeecheung joyeecheung mentioned this pull request Jun 16, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Jun 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23966/
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member Author

sam-github commented Jun 19, 2019

The notifications didn't get picked up by github, but the last CI passed. @nodejs/lts
@BethGriggs BethGriggs requested a review from shigeki Aug 7, 2019
indutny and others added 6 commits Jan 8, 2014
@indutny @sam-github
deps: fix openssl assembly error on ia32 win32
652ab26 
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Shigeki Ohtsu @sam-github
deps: fix asm build error of openssl in x86_win32
5883066 
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Shigeki Ohtsu @sam-github
openssl: fix keypress requirement in apps on win32
be6502d 
Reapply b910613 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Shigeki Ohtsu @sam-github
deps: add -no_rand_screen to openssl s_client
Loading status checks…
d3f13c1 
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@sam-github
deps: upgrade openssl sources to 1.0.2s
89ab949
@sam-github
deps: copy all openssl header files to include dir
Loading status checks…
f2c3c9a
@sam-github sam-github force-pushed the sam-github:update-openssl-1.0.2s-v8.x branch from 0a37768 to d3f13c1 Sep 5, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25365/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25573/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25578/
@BethGriggs
BethGriggs approved these changes Sep 19, 2019
View changes
@BethGriggs

This comment has been minimized.

Sign in to view
Copy link
Member

BethGriggs commented Sep 19, 2019

Landed on v8.x-staging
@BethGriggs BethGriggs closed this Sep 19, 2019
BethGriggs added a commit that referenced this pull request Sep 19, 2019
@sam-github @BethGriggs
deps: upgrade openssl sources to 1.0.2s
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
dc9d645 
PR-URL: #28230
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Sep 19, 2019
@sam-github @BethGriggs
deps: copy all openssl header files to include dir
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
da99d3f 
PR-URL: #28230
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Sep 19, 2019
@indutny @BethGriggs
deps: fix openssl assembly error on ia32 win32
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
87eee99 
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: #589
Backport-PR-URL: #28230
PR-URL: #1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
BethGriggs added a commit that referenced this pull request Sep 19, 2019
Shigeki Ohtsu @BethGriggs
deps: fix asm build error of openssl in x86_win32
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
9663ae3 
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: #589
Backport-PR-URL: #28230
PR-URL: #1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs added a commit that referenced this pull request Sep 19, 2019
Shigeki Ohtsu @BethGriggs
openssl: fix keypress requirement in apps on win32
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
dd28596 
Reapply b910613 .

Fixes: #589
Backport-PR-URL: #28230
PR-URL: #1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs added a commit that referenced this pull request Sep 19, 2019
Shigeki Ohtsu @BethGriggs
deps: add -no_rand_screen to openssl s_client
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
5682e50 
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
Backport-PR-URL: #28230
PR-URL: #1836
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs added a commit that referenced this pull request Sep 19, 2019
@BethGriggs
2019-10-08, Version 8.16.2 'Carbon' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
59ae17e 
Node.js 8 is due to go End-of-Life on 31st December 2019.

Notable changes:

- **deps**: upgrade openssl sources to 1.0.2s (Sam Roberts)
  [#28230](#28230)

PR-URL:
@BethGriggs BethGriggs mentioned this pull request Sep 19, 2019
Merged
BethGriggs added a commit that referenced this pull request Sep 25, 2019
@BethGriggs
2019-10-08, Version 8.16.2 'Carbon' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
ad698a3 
Node.js 8 is due to go End-of-Life on 31st December 2019.

Notable changes:

- **deps**: upgrade openssl sources to 1.0.2s (Sam Roberts)
  [#28230](#28230)

PR-URL:
BethGriggs added a commit that referenced this pull request Sep 25, 2019
@BethGriggs
2019-10-08, Version 8.16.2 'Carbon' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
d5c29b8 
Node.js 8 is due to go End-of-Life on 31st December 2019.

Notable changes:

- **deps**: upgrade openssl sources to 1.0.2s (Sam Roberts)
  [#28230](#28230)

PR-URL: #29617
BethGriggs added a commit that referenced this pull request Oct 9, 2019
@BethGriggs
2019-10-09, Version 8.16.2 'Carbon' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
4efffd5 
Node.js 8 is due to go End-of-Life on 31st December 2019.

Notable changes:

- **deps**: upgrade openssl sources to 1.0.2s (Sam Roberts)
  [#28230](#28230)

PR-URL: #29617
BethGriggs added a commit that referenced this pull request Oct 9, 2019
@BethGriggs
2019-10-09, Version 8.16.2 'Carbon' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
a04b04f 
Node.js 8 is due to go End-of-Life on 31st December 2019.

Notable changes:

- **deps**: upgrade openssl sources to 1.0.2s (Sam Roberts)
  [#28230](#28230)

PR-URL: #29617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs

@shigeki shigeki

Assignees
No one assigned
Labels
openssl v8.x
Projects
None yet
Milestone
No milestone
4 participants
@sam-github @nodejs-github-bot @BethGriggs @indutny
You can’t perform that action at this time.