tools: python3 compat for inspector code generator

The code generator takes a dict and turns it into a namedtuple. The dict contains the key "async", which is a keyword in python 3.7, and rejected by the namedtuple constructor. Rename it to "async_" to avoid the clash. Fixes: #29326 PR-URL: #29340 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Sep 25, 2019 · bc7cc348cc0ad9fe7ddd909e9e2ee5ef5de3c377 · bc7cc34
1 parent 2dc52ad
commit bc7cc348cc0ad9fe7ddd909e9e2ee5ef5de3c377
Showing with 4 additions and 1 deletion.

+4 −1 tools/inspector_protocol/code_generator.py
diff --git a/tools/inspector_protocol/code_generator.py b/tools/inspector_protocol/code_generator.py
@@ -41,6 +41,9 @@ def json_object_hook(object_dict):
             items = [(k, os.path.join(output_base, v) if k == "path" else v) for (k, v) in object_dict.items()]
             items = [(k, os.path.join(output_base, v) if k == "output" else v) for (k, v) in items]
             keys, values = list(zip(*items))
+            # 'async' is a python 3.7 keyword. Don't use namedtuple(rename=True)
+            # because that only renames it in python 3 but not python 2.
+            keys = tuple('async_' if k == 'async' else k for k in keys)
             return collections.namedtuple('X', keys)(*values)
         return json.loads(data, object_hook=json_object_hook)
 
@@ -521,7 +524,7 @@ def generate_type(self, domain, typename):
     def is_async_command(self, domain, command):
         if not self.config.protocol.options:
             return False
-        return self.check_options(self.config.protocol.options, domain, command, "async", None, False)
+        return self.check_options(self.config.protocol.options, domain, command, "async_", None, False)
 
 
     def is_exported(self, domain, name):