buffer: correct indexOf() error message

PR-URL: #29217 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · Aug 20, 2019 · 71aaf590c13d597add3d34f41c8fe70e909ba385 · 71aaf59
1 parent c900762
commit 71aaf590c13d597add3d34f41c8fe70e909ba385
Unified Split

Showing with 4 additions and 3 deletions.

+1 −1 lib/buffer.js

+1 −0 test/parallel/test-bootstrap-modules.js

+1 −1 test/parallel/test-buffer-includes.js

+1 −1 test/parallel/test-buffer-indexof.js
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -907,7 +907,7 @@ function bidirectionalIndexOf(buffer, val, byteOffset, encoding, dir) {
  }
  throw new ERR_INVALID_ARG_TYPE(
-  
-    'value', ['string', 'Buffer', 'Uint8Array'], val
+  
+    'value', ['number', 'string', 'Buffer', 'Uint8Array'], val
  );
 }

diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -22,6 +22,7 @@ const expectedModules = new Set([
  'Internal Binding native_module',
  'Internal Binding options',
  'Internal Binding process_methods',
+  
+  'Internal Binding string_decoder',
  'Internal Binding task_queue',
  'Internal Binding timers',
  'Internal Binding trace_events',

diff --git a/test/parallel/test-buffer-includes.js b/test/parallel/test-buffer-includes.js
@@ -282,7 +282,7 @@ for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
    {
      code: 'ERR_INVALID_ARG_TYPE',
      type: TypeError,
-  
-      message: 'The "value" argument must be one of type string, ' +
+  
+      message: 'The "value" argument must be one of type number, string, ' +
               `Buffer, or Uint8Array. Received type ${typeof val}`
    }
  );

diff --git a/test/parallel/test-buffer-indexof.js b/test/parallel/test-buffer-indexof.js
@@ -357,7 +357,7 @@ assert.strictEqual(Buffer.from('aaaaa').indexOf('b', 'ucs2'), -1);
    {
      code: 'ERR_INVALID_ARG_TYPE',
      type: TypeError,
-  
-      message: 'The "value" argument must be one of type string, ' +
+  
+      message: 'The "value" argument must be one of type number, string, ' +
               `Buffer, or Uint8Array. Received type ${typeof val}`
    }
  );