Skip to content

/ python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #916

Merged
merged 3 commits into from Aug 13, 2019
Merged

Add issue templates #916

merged 3 commits into from Aug 13, 2019

Conversation

@scottilee
Copy link
Contributor

scottilee commented Aug 4, 2019

Sets up issue templates for documentation, questions, bug reports, and feature requests. This should help triaging issues and make sure that issue filers are including relevant information.

Fixes #912.
@scottilee
Add issue templates
Loading status checks…
686048c
@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and mbohlool Aug 4, 2019
@roycaihw
Copy link
Member

roycaihw commented Aug 6, 2019

/cc
@k8s-ci-robot k8s-ci-robot requested a review from roycaihw Aug 6, 2019
@roycaihw
Copy link
Member

roycaihw commented Aug 7, 2019

It seems that the emeritus_approvers label doesn't prevent the bot from requesting reviews

python/OWNERS

Lines 6 to 9 in 1d51d5a

emeritus_approvers:
- caesarxuchao
- lavalamp
- mbohlool

@micw523
Copy link
Member

micw523 commented Aug 7, 2019

@roycaihw it did. This was sent out before that PR was approved
@roycaihw
roycaihw reviewed Aug 7, 2019
View changes
.github/ISSUE_TEMPLATE/bug.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question.md Outdated Show resolved Hide resolved
@scottilee
Include feedback fixes
Loading status checks…
e74cd71
@micw523
micw523 reviewed Aug 9, 2019
View changes
Copy link
Member

micw523 left a comment

Functionality means the state of being functional. We should rather say “a function not currently being supported” or something like that.

Where did you pull these templates from?
@scottilee
Fix wording
Loading status checks…
f4a47ed
@scottilee
Copy link
Contributor Author

scottilee commented Aug 9, 2019

@micw523 random places but I fixed the wording. Thanks for the catch.
@roycaihw
Copy link
Member

roycaihw commented Aug 13, 2019

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, scottilee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot merged commit 9dbbc69 into kubernetes-client:master Aug 13, 2019
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation scottilee authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scottilee scottilee mentioned this pull request Aug 27, 2019
Closed
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw

@micw523 micw523

@mbohlool mbohlool

@caesarxuchao caesarxuchao

Assignees

@roycaihw roycaihw

Labels
approved cncf-cla: yes lgtm size/M tide/merge-method-squash
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Setup Issue Templates
4 participants
@scottilee @roycaihw @micw523 @k8s-ci-robot
You can’t perform that action at this time.