Skip to content

/ octodns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geo record zone tests #137

Open
wants to merge 1 commit into
base: geo-cname
from
Open

Add Geo record zone tests #137

wants to merge 1 commit into from
+68 −0

Conversation

@vanbroup
Copy link
Contributor

vanbroup commented Oct 31, 2017

@ross, I started to add some test geo records and it looks like the A, AAAA and the new CNAME all fail to detect the zone changes?

I don't see any code related to geo records in the changes function of zone.py (line 99), have you left that out on purpose?

Related to: #62
@vanbroup
Add Geo zone tests
Loading status checks…
16f1450
@ross
Copy link
Contributor

ross commented Oct 31, 2017

I don't see any code related to geo records in the changes function of zone.py (line 99), have you left that out on purpose?

It was definitely WIP and it's been long enough that I don't recall the exact status of the code. I think it was able to create them from scratch, but there may have been issues with the health checks. I don't think I made it to the point of testing changes. If I had to guess I'd say there's probably a few days to a week of work if I was able to sit down and work on it un-interrupted to get it shipped. Unfortunately not something I'll be able to do soon.
@vanbroup
Copy link
Contributor Author

vanbroup commented Oct 31, 2017

My question is not really about CNAME or the branch but this looks to be failing for all GeoIP record types? Is that something you are aware of?
@ross
Copy link
Contributor

ross commented Oct 31, 2017

My question is not really about CNAME or the branch but this looks to be failing for all GeoIP record types? Is that something you are aware of?

I'm sure I ran the tests so probably was aware of it at the time. 😕 At the very least I'm not surprised. It definitely wasn't a finished product.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vanbroup @ross
You can’t perform that action at this time.