Skip to content

/ certbot

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about Python 3.4 deprecation #7367

Closed
bmw opened this issue Sep 6, 2019 · 0 comments
Closed

Warn about Python 3.4 deprecation #7367

bmw opened this issue Sep 6, 2019 · 0 comments
Labels
area: code health area: logging area: python area: ui / ux easy-fix has pr
Milestone
1.1.0

Comments

@bmw
Copy link
Member

@bmw bmw commented Sep 6, 2019

Once #7268 lands, we should warn about Certbot and its components deprecating Python 3.4 support. To do this we should:

  1. Have acme use Python's warning system to register deprecation warnings.
  2. Log warnings using the logging module in Certbot.

You can see how we did this for previous versions of Python in our git history.
@bmw bmw added this to the 0.39.0 milestone Sep 6, 2019
@sydneyli sydneyli self-assigned this Sep 13, 2019
@sydneyli sydneyli mentioned this issue Sep 16, 2019
Merged
2 of 2 tasks complete
@bmw bmw added the has pr label Sep 17, 2019
@bmw bmw modified the milestones: 0.39.0, 0.40.0 Oct 1, 2019
@bmw bmw closed this in #7378 Oct 30, 2019
bmw added a commit that referenced this issue Oct 30, 2019
@sydneyli @bmw
Deprecation warnings for Python 3.4 (#7378)
Loading status checks…
6fcdfb0 
Fixes #7367

* Deprecation warnings for Python 3.4 users

* CHANGELOG.md and AUTHORS.md

* double equals typo
@bmw bmw reopened this Nov 6, 2019
@bmw bmw modified the milestones: 0.40.0, 1.0.0 Nov 6, 2019
@adferrand adferrand mentioned this issue Nov 6, 2019
Merged
@bmw bmw modified the milestones: 1.0.0, 1.1.0 Nov 19, 2019
@bmw bmw unassigned sydneyli Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: code health area: logging area: python area: ui / ux easy-fix has pr
Projects
None yet
Milestone
1.1.0
Linked pull requests

Successfully merging a pull request may close this issue.

Deprecation warnings for Python 3.4
Fix certbot-auto regarding python 3.4 -> python 3.6 migration for CentOS 6 users
2 participants
@sydneyli @bmw
You can’t perform that action at this time.