Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooling): wait for emulator before running adb commands #912

Merged
merged 3 commits into from Jan 5, 2018

Conversation

@Plamen5kov
Copy link
Contributor

@Plamen5kov Plamen5kov commented Jan 4, 2018

problem
We try to run adb commands before the device is ready to receive them. Devices/Emulators may pass through different states like: device is offline or the bootup animation is still running.

solution
Make the test tooling wait for the emulator to be fully operation before running any adb commands or even installing the app to prevent running commands too early.

@Plamen5kov Plamen5kov requested review from petekanev and KristianDD Jan 4, 2018
…with user template (#891)"

This reverts commit 81f70ad.
@ns-bot
Copy link

@ns-bot ns-bot commented Jan 4, 2018

💔

@Plamen5kov Plamen5kov force-pushed the plamen5kov/wait-for-emulator branch from caddd6c to 65ac5c3 Jan 4, 2018
@Plamen5kov Plamen5kov force-pushed the plamen5kov/wait-for-emulator branch from a3888da to f26c787 Jan 4, 2018
@ns-bot
Copy link

@ns-bot ns-bot commented Jan 4, 2018

💔

1 similar comment
@ns-bot
Copy link

@ns-bot ns-bot commented Jan 4, 2018

💔

@Natalia-Hristova
Copy link
Contributor

@Natalia-Hristova Natalia-Hristova commented Jan 4, 2018

run ci

Copy link
Contributor

@petekanev petekanev left a comment

The change is based on the reverted master branch. Let's merge #914 before we go ahead with this one?

@ns-bot
Copy link

@ns-bot ns-bot commented Jan 4, 2018

💔

@Natalia-Hristova
Copy link
Contributor

@Natalia-Hristova Natalia-Hristova commented Jan 4, 2018

run ci

@ns-bot
Copy link

@ns-bot ns-bot commented Jan 4, 2018

💔

@Natalia-Hristova
Copy link
Contributor

@Natalia-Hristova Natalia-Hristova commented Jan 5, 2018

run ci

@ns-bot
Copy link

@ns-bot ns-bot commented Jan 5, 2018

💚

@Plamen5kov Plamen5kov merged commit 07c8140 into master Jan 5, 2018
2 checks passed
2 checks passed
ci/jenkins/unit-tests Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Plamen5kov Plamen5kov deleted the plamen5kov/wait-for-emulator branch Jan 5, 2018
@Natalia-Hristova Natalia-Hristova restored the plamen5kov/wait-for-emulator branch Jan 5, 2018
@Natalia-Hristova
Copy link
Contributor

@Natalia-Hristova Natalia-Hristova commented Jan 5, 2018

run ci

1 similar comment
@Natalia-Hristova
Copy link
Contributor

@Natalia-Hristova Natalia-Hristova commented Jan 5, 2018

run ci

@Plamen5kov
Copy link
Contributor Author

@Plamen5kov Plamen5kov commented Jan 5, 2018

run CI

@Plamen5kov Plamen5kov deleted the plamen5kov/wait-for-emulator branch Jan 5, 2018
Plamen5kov added a commit that referenced this pull request Jan 5, 2018
Plamen5kov added a commit that referenced this pull request Jan 16, 2018
Plamen5kov added a commit that referenced this pull request Feb 12, 2018
petekanev added a commit that referenced this pull request Feb 26, 2018
Plamen5kov added a commit that referenced this pull request Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.