Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.6] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520) #11032
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Dec 7, 2018
bedevere-bot
added
skip news
type-tests
awaiting review
labels
Dec 7, 2018
brettcannon
added
the
🤖 automerge
label
Dec 7, 2018
This comment has been minimized.
This comment has been minimized.
|
@onyb and @brettcannon: Status check is done, and it's a success |
serhiy-storchaka
approved these changes
Dec 11, 2018
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Dec 11, 2018
miss-islington
merged commit 7d9f219
into
python:3.6
Dec 11, 2018
6 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
"skip news" label found
bedevere-bot
removed
the
awaiting merge
label
Dec 11, 2018
miss-islington
deleted the
miss-islington:backport-3cf7438-3.6
branch
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
miss-islington commentedDec 7, 2018
•
edited by bedevere-bot
(cherry picked from commit 3cf7438)
Co-authored-by: Anirudha Bose ani07nov@gmail.com
https://bugs.python.org/issue33747