Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: validate fds as int32s #28984

Closed
wants to merge 1 commit into from
+43 −26

Conversation

@cjihrig
Copy link
Contributor

commented Aug 5, 2019

This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

Fixes: #28980

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@cjihrig
fs: validate fds as int32s 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
25dd021

@nodejs-github-bot nodejs-github-bot added the fs label Aug 5, 2019

@targos
targos approved these changes Aug 5, 2019
View changes
@devsnek
devsnek approved these changes Aug 5, 2019
View changes
@bnoordhuis
bnoordhuis approved these changes Aug 6, 2019
View changes
@jasnell
jasnell approved these changes Aug 7, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24884/
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24885/
@Trott
Trott approved these changes Aug 7, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 7, 2019

Landed in c072a80

@Trott Trott closed this Aug 7, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 7, 2019
@cjihrig @Trott
fs: validate fds as int32s 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: nodejs#28984
Fixes: nodejs#28980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
c072a80

@cjihrig cjihrig deleted the cjihrig:fds branch Aug 8, 2019

targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
fs: validate fds as int32s 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: #28984
Fixes: #28980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
5b7a2e3
targos added a commit that referenced this pull request Aug 19, 2019
@cjihrig @targos
fs: validate fds as int32s 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: #28984
Fixes: #28980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
f194626
@targos targos referenced this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
fs: validate fds as int32s 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: nodejs#28984
Fixes: nodejs#28980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
b69fb37
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@cjihrig @JeniaBR
fs: validate fds as int32s 
This commit updates the JS layer's validation of file
descriptors to check for int32s >= 0 instead of uint32s.

PR-URL: nodejs#28984
Fixes: nodejs#28980
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
05a2e31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@Trott Trott

@targos targos

@devsnek devsnek

Assignees
No one assigned
Labels
fs
Projects
None yet
Milestone
No milestone
7 participants
@cjihrig @nodejs-github-bot @Trott @bnoordhuis @jasnell @targos @devsnek
You can’t perform that action at this time.