Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add undecorated classes migration faq #32478

Closed

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Sep 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add info in deprecations guide about migrating undecorated classes.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kapunahelewong kapunahelewong requested a review from kara Sep 4, 2019
@kapunahelewong kapunahelewong requested a review from as a code owner Sep 4, 2019
@ngbot ngbot bot added this to the Backlog milestone Sep 4, 2019
@ngbot ngbot bot added this to the Backlog milestone Sep 4, 2019
@ngbot ngbot bot added this to the Backlog milestone Sep 4, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 4, 2019

@kapunahelewong kapunahelewong added this to In Progress in docs Sep 5, 2019
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 9, 2019

aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 9, 2019

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 9, 2019

aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
aio/content/guide/deprecations.md Outdated Show resolved Hide resolved
@devversion
Copy link
Member

@devversion devversion commented Sep 10, 2019

@kara @kapunahelewong I just want to add that this migration also handles the DI case for undecorated base classes of @Injectable's.

Also it copies the metadata for undecorated derived classes where the inherited metadata is from a @Pipe(). These two things aren't covered by the document yet. I'm not sure where/whether we should add those.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 10, 2019

@kara kara requested a review from jelbourn Sep 10, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 12, 2019

@kapunahelewong
Copy link
Contributor Author

@kapunahelewong kapunahelewong commented Sep 12, 2019

@jelbourn thanks for your patience. It's ready for your review. I changed the names of the classes and selectors in the example code, but if it needs to be more concrete, I'd love some pointers. Not sure if I hit the mark on that one.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 12, 2019

Copy link
Member

@jelbourn jelbourn left a comment

LGTM, one tiny nit

aio/content/guide/migration-undecorated-classes.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 12, 2019

kara
kara approved these changes Sep 12, 2019
Copy link
Contributor

@kara kara left a comment

LGTM

@kara
Copy link
Contributor

@kara kara commented Sep 12, 2019

merge-assistance: global approval

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 12, 2019

kara added a commit that referenced this issue Sep 12, 2019
@kapunahelewong kapunahelewong deleted the dec-classes-migration branch Sep 12, 2019
@kapunahelewong kapunahelewong moved this from In Progress to In Review in docs Sep 16, 2019
@kapunahelewong kapunahelewong moved this from In Review to Waiting for Approval in docs Sep 16, 2019
@kapunahelewong kapunahelewong moved this from Waiting for Approval to Done in docs Sep 16, 2019
arnehoek added a commit to arnehoek/angular that referenced this issue Sep 26, 2019
kapunahelewong added a commit to kapunahelewong/angular that referenced this issue Oct 2, 2019
kara added a commit to kara/angular that referenced this issue Oct 2, 2019
kapunahelewong added a commit to kapunahelewong/angular that referenced this issue Oct 2, 2019
atscott added a commit that referenced this issue Oct 2, 2019
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Oct 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
docs
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants