New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add undecorated classes migration faq #32478
docs: add undecorated classes migration faq #32478
Conversation
f100bd8
to
768c52a
Compare
|
You can preview 768c52a at https://pr32478-768c52a.ngbuilds.io/. |
768c52a
to
e90a5d1
Compare
|
You can preview e90a5d1 at https://pr32478-e90a5d1.ngbuilds.io/. |
e90a5d1
to
f69016d
Compare
|
You can preview f69016d at https://pr32478-f69016d.ngbuilds.io/. |
f69016d
to
a8f4ee0
Compare
|
You can preview a8f4ee0 at https://pr32478-a8f4ee0.ngbuilds.io/. |
|
@kara @kapunahelewong I just want to add that this migration also handles the DI case for undecorated base classes of Also it copies the metadata for undecorated derived classes where the inherited metadata is from a |
a8f4ee0
to
7788b31
Compare
|
You can preview 7788b31 at https://pr32478-7788b31.ngbuilds.io/. |
|
You can preview 6bdebe4 at https://pr32478-6bdebe4.ngbuilds.io/. |
|
@jelbourn thanks for your patience. It's ready for your review. I changed the names of the classes and selectors in the example code, but if it needs to be more concrete, I'd love some pointers. Not sure if I hit the mark on that one. |
|
You can preview a18d185 at https://pr32478-a18d185.ngbuilds.io/. |
a18d185
to
c8e9b38
Compare
c8e9b38
to
5359874
Compare
|
You can preview c8e9b38 at https://pr32478-c8e9b38.ngbuilds.io/. |
|
merge-assistance: global approval |
|
You can preview 5359874 at https://pr32478-5359874.ngbuilds.io/. |
This reverts commit bd67958.
This reverts commit bd67958.
This reverts commit bd67958.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Add info in deprecations guide about migrating undecorated classes.
Does this PR introduce a breaking change?
Other information