Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): unable to bind to properties that start with class or style #32421

Closed
wants to merge 1 commit into from
+47 −4

Conversation

@crisbeto
Copy link
Member

commented Aug 30, 2019 •
edited

Fixes Ivy picking up property bindings that start with class or style as if they're style bindings.

Fixes #32310.
@googlebot googlebot added the cla: yes label Aug 30, 2019
@crisbeto crisbeto force-pushed the crisbeto:FW-1533/inputs-styling branch from 7ac94d5 to 7bbc774 Aug 30, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 30, 2019
@crisbeto crisbeto marked this pull request as ready for review Aug 30, 2019
@crisbeto crisbeto requested review from angular/fw-compiler as code owners Aug 30, 2019
@kara
kara approved these changes Aug 30, 2019
View changes
Copy link
Contributor

left a comment

LGTM
@kara

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 30, 2019

@crisbeto Can we amend the commit message to say that it closes #32310?
@crisbeto crisbeto force-pushed the crisbeto:FW-1533/inputs-styling branch from 7bbc774 to 9e6effc Aug 30, 2019
@crisbeto

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Aug 30, 2019

Added the closes reference to the commit message.
@crisbeto crisbeto force-pushed the crisbeto:FW-1533/inputs-styling branch from 9e6effc to 5517bf6 Aug 30, 2019
@kara

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 30, 2019 •
edited

VE presubmit

Ivy presubmit
@matsko
matsko reviewed Aug 30, 2019
View changes
packages/compiler/src/render3/view/styling_builder.ts Show resolved Hide resolved
@crisbeto
fix(ivy): unable to bind to properties that start with class or style
Loading status checks…
73da5fc 
Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes #32310
@crisbeto crisbeto force-pushed the crisbeto:FW-1533/inputs-styling branch from 5517bf6 to 73da5fc Sep 5, 2019
@ngbot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 5, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_aio" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.
@kara

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 5, 2019

merge-assistance: global approval
@matsko matsko closed this in 62d92f8 Sep 5, 2019
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@crisbeto @sabeersulaiman
fix(ivy): unable to bind to properties that start with class or style (…
b58b979 
…angular#32421)

Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes angular#32310

PR Close angular#32421
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@crisbeto @arnehoek
fix(ivy): unable to bind to properties that start with class or style (…
21c4a88 
…angular#32421)

Fixes Ivy picking up property bindings that start with `class` or `style` as if they're style bindings.

Fixes angular#32310

PR Close angular#32421
@angular-automatic-lock-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsko matsko

@jelbourn jelbourn

@kara kara

@gkalpak gkalpak

@angular/fw-compiler fw-compiler

Assignees
No one assigned
Labels
PR action: merge PR action: merge-assistance PR target: master-only cla: yes comp: ivy
Projects
None yet
Milestone
  needsTriage
6 participants
@crisbeto @kara @matsko @jelbourn @gkalpak @googlebot
You can’t perform that action at this time.