Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: port accessibility app from stackblitz to aio #32377

Closed
wants to merge 1 commit into from
Closed

docs: port accessibility app from stackblitz to aio #32377

wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Aug 28, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently, the example is solely on stackblitz and is not in aio, so the example code is inline rather than from a compiled app.

Issue Number: Fixes #32320

Inspired by PR #32261 in which a discrepancy between the code in the actual app and the inline code snippets was fixed.

What is the new behavior?

Now there's an aio example app for the accessibility guide. This way it can be maintained along with the other aio examples and we can use live code snippets in the doc.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Adds:

  1. docregions
  2. the same example as is in current use, except in aio in aio/content/examples/accessibility
  3. e2e tests

@kapunahelewong kapunahelewong requested a review from IgorMinar as a code owner Aug 28, 2019
@ngbot ngbot bot added this to the Backlog milestone Aug 28, 2019
@ngbot ngbot bot added this to the Backlog milestone Aug 28, 2019
@kapunahelewong kapunahelewong force-pushed the accessibility-example branch 3 times, most recently from a56b842 to 6ff717a Compare Aug 28, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Aug 28, 2019

You can preview a56b842 at https://pr32377-a56b842.ngbuilds.io/.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Aug 28, 2019

You can preview 6ff717a at https://pr32377-6ff717a.ngbuilds.io/.

@kapunahelewong kapunahelewong requested a review from jelbourn Aug 28, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Aug 28, 2019

You can preview f6dae03 at https://pr32377-f6dae03.ngbuilds.io/.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Aug 28, 2019

You can preview 29e3fe0 at https://pr32377-29e3fe0.ngbuilds.io/.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Aug 28, 2019

You can preview 5b560ce at https://pr32377-5b560ce.ngbuilds.io/.

jelbourn
jelbourn approved these changes Aug 28, 2019
View changes
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

@kapunahelewong
Copy link
Contributor Author

@kapunahelewong kapunahelewong commented Aug 29, 2019

FYI, here's the preview: https://pr32377-5b560ce.ngbuilds.io/guide/accessibility#case-study-building-a-custom-progress-bar (see the two code examples in that section)

gkalpak
gkalpak approved these changes Aug 29, 2019
View changes
Copy link
Member

@gkalpak gkalpak left a comment

I left a couple of minor comments, but otherwise LGTM 💯
Also, not directly related to this PR, but it would be nice to have a code-woner for the accessibility docs.

aio/content/examples/accessibility/src/app/app.module.ts Outdated Show resolved Hide resolved
aio/content/examples/accessibility/src/app/app.component.html Outdated Show resolved Hide resolved
aio/content/examples/accessibility/e2e/src/app.e2e-spec.ts Outdated Show resolved Hide resolved
aio/content/examples/accessibility/e2e/src/app.e2e-spec.ts Outdated Show resolved Hide resolved
@kapunahelewong kapunahelewong force-pushed the accessibility-example branch 2 times, most recently from 401bd4d to 6c22727 Compare Sep 3, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 3, 2019

You can preview 6c22727 at https://pr32377-6c22727.ngbuilds.io/.

@mary-poppins
Copy link

@mary-poppins mary-poppins commented Sep 6, 2019

You can preview 02010b8 at https://pr32377-02010b8.ngbuilds.io/.

@kapunahelewong
Copy link
Contributor Author

@kapunahelewong kapunahelewong commented Sep 6, 2019

Caretaker, this is a docs only change. Thank you!

matsko added a commit that referenced this issue Sep 10, 2019
@kapunahelewong @matsko
docs: port accessibility app from stackblitz to aio (#32377)
38f4dcd 
Fixes #32320

PR Close #32377
@kapunahelewong kapunahelewong added this to Done in docs Sep 16, 2019
arnehoek added a commit to arnehoek/angular that referenced this issue Sep 26, 2019
@kapunahelewong @arnehoek
docs: port accessibility app from stackblitz to aio (angular#32377)
ba08297 
Fixes angular#32320

PR Close angular#32377
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Oct 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
@kapunahelewong kapunahelewong deleted the accessibility-example branch Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar

@jelbourn jelbourn

@gkalpak gkalpak

Assignees
No one assigned
Labels
action: merge cla: yes comp: docs effort1: hours risk: low target: patch type: bug/fix
Projects
docs
Done
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

Port Accessibility example and add docregions
6 participants
@kapunahelewong @mary-poppins @IgorMinar @jelbourn @gkalpak @googlebot