build: bump yarn requirement to 1.17.3#32344
Conversation
josephperrott
added
action: merge
josephperrott
force-pushed
the
yarn-update
branch
2 times, most recently
from
58b723a to
99365f4
Compare
josephperrott
force-pushed
the
yarn-update
branch
from
99365f4 to
1667c8c
Compare
|
@gkalpak Correct, done. |
| @@ -73,7 +76,7 @@ node_repositories( | |||
| # It possible that versions of yarn past 1.13.0 do not have this issue, however, before | |||
| # advancing this version we need to test manually on Windows that the above error does not | |||
| # happen as the issue is not caught by CI. | |||
There was a problem hiding this comment.
Have you checked whether this issue is fixed on Windows? If it is, we should remove the comment. If it isn't, then we have a problem 😁
(I could check, but I don't know how to reproduce the issue - I looked at the related issue, but didn't find anything.)
There was a problem hiding this comment.
I think you could repro on windows by just doing two yarn bazel build ... in a row? @gregmagolan might remember.
|
@devversion did some builds with it and didn't see any issues. Though we didn't know how to specifically repro it so we couldn't be entirely sure. From my understanding he did multiple |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
No description provided.