Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a settings option to allow MediaFile translations to be skipped #679
Conversation
|
Ah, nice, thank you. It gives an easy speed bump if translations aren't used (eg. I don't think we use mediafile translations. Anywhere). Could you fix the travis check? (make line 143 in default_settings.py shorter, and perhaps move the "if trans" block into the if settings.FEINCMS_MEDIAFILE_TRANSLATIONS? |
|
@mjl sure thing - should be done now :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This new setting is specifically targeting a fix for #675
To be clear, this isn't really a solution to the problem, basically the root of the issue here is that the
translationslazy-eval property is largely inefficient (perhaps just in certain cases, but at Thread we're seeing this be really costly, given hundreds ofMediaFiles)But at the same time, as a feature I think it makes sense regardless - and it fortunately sidesteps the root issue very nicely.