Skip to content

/ python-qrcode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage, add py37 checks, backward capability with py27 #167

Merged
merged 2 commits into from Mar 19, 2019
Merged

Improve test coverage, add py37 checks, backward capability with py27 #167

merged 2 commits into from Mar 19, 2019

Conversation

@zifter
Copy link

zifter commented Feb 24, 2019

No description provided.

o_strokachuk
Improve test coverage, add py37 checks, backward capability with pyth…
bb8f425 
…on 2.7
@zifter zifter force-pushed the zifter:improve_tests branch from 91c2d3e to bb8f425 Feb 25, 2019
@SmileyChris
SmileyChris reviewed Feb 27, 2019
View changes
Copy link
Member

SmileyChris left a comment

Looking good, thanks for your work
qrcode/image/base.py Outdated Show resolved Hide resolved
qrcode/image/base.py Outdated Show resolved Hide resolved
qrcode/image/base.py Outdated Show resolved Hide resolved
o_strokachuk
Remove raise exception in abstract method
603498c
@zifter zifter mentioned this pull request Feb 28, 2019
Open
@zifter
Copy link
Author

zifter commented Mar 4, 2019

@SmileyChris, hi!
I've fixed review notes, is it possible to merge it?
@SmileyChris SmileyChris merged commit 92e3f59 into lincolnloop:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmileyChris SmileyChris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zifter @SmileyChris
You can’t perform that action at this time.