Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[Fix #104] Exclude Rails-independent `bin/bundle` by default #108
Conversation
Resolves #104. `bin/bundle` was generated by Bundler. And Bundler doesn't depend on Active Support (Rails). This PR prevents the following error. ```console % cd path/to/new-rails-app % bin/rails -v Rails 6.0.0.rc2 % bundle exec rubocop -a --only Rails/Present % g diff diff --git a/bin/bundle b/bin/bundle index 4f5e057..fa7b83b 100755 --- a/bin/bundle +++ b/bin/bundle @@ -39,7 +39,7 @@ m = Module.new do def gemfile gemfile = ENV["BUNDLE_GEMFILE"] - return gemfile if gemfile && !gemfile.empty? + return gemfile if gemfile.present? File.expand_path("../../Gemfile", __FILE__) end % ./bin/bundle Traceback (most recent call last): 2: from ./bin/bundle:101:in `<main>' 1: from ./bin/bundle:71:in `load_bundler!' ./bin/bundle:42:in `gemfile': undefined method `present?' for nil:NilClass (NoMethodError) ```
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Jan 17, 2020
Fixes rubocop-hq#122. `Exclude` defined in RuboCop core was not inherited. https://github.com/rubocop-hq/rubocop/blob/v0.79.0/config/default.yml#L60-L64 This PR fixes `Exclude` paths that were not inherited. This bug was caused by rubocop-hq#108.
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Jan 17, 2020
Fixes rubocop-hq#122. `Exclude` defined in RuboCop core was not inherited. https://github.com/rubocop-hq/rubocop/blob/v0.79.0/config/default.yml#L60-L64 This PR fixes `Exclude` paths that were not inherited. This bug was caused by rubocop-hq#108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Resolves #104.
bin/bundlewas generated by Bundler. And Bundler doesn't depend on Active Support (Rails).This PR prevents the following error.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.