Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
broken pcre detection is broken #1013
Closed
Labels
Comments
|
Right now the only fallout of this is the PCRE tests are all |
kvalkhof75
pushed a commit
to kvalkhof75/pre-commit
that referenced
this issue
Dec 5, 2019
I'm still a beginner, but a single single quote looked a bit off to me. Could adding another single quote after pre fix this issue?
kvalkhof75
pushed a commit
to kvalkhof75/pre-commit
that referenced
this issue
Dec 5, 2019
Changed the string and file referenced to handle single quotes properly inside pcre greps.
kvalkhof75
pushed a commit
to kvalkhof75/pre-commit
that referenced
this issue
Dec 5, 2019
Properly changed the string and file referenced to handle single quotes properly inside pcre greps.
kvalkhof75
pushed a commit
to kvalkhof75/pre-commit
that referenced
this issue
Dec 5, 2019
One again changed the string and file referenced to handle single quotes properly inside pcre greps.
kvalkhof75
pushed a commit
to kvalkhof75/pre-commit
that referenced
this issue
Dec 5, 2019
Could this fix pre-commit#1013?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pre-commit/testing/util.py
Lines 69 to 71 in 09e64e8
When I moved to declarative metadata this got broken.
This'll need to be updated to look at something else. Before it was making sure that single quotes were being handled properly inside pcre greps (since this is broken in the msys implementation of
grep -P)