Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisualStudio] add Logs folder #3143

Merged
merged 3 commits into from Sep 20, 2019
Merged

[VisualStudio] add Logs folder #3143

merged 3 commits into from Sep 20, 2019

Conversation

@paulsmithkc
Copy link
Contributor

@paulsmithkc paulsmithkc commented Aug 6, 2019

Reasons for making this change:

  • The singular form of the Log folder is included in the ignore file, but not the plural form.

Links to documentation supporting these rule changes:

https://stackoverflow.com/questions/9745119/git-ignore-file-still-commits-logs

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Aug 7, 2019

@paulsmithkc can we document which tool is generating the Logs folder? We did this for Log back in #1415 and I want to confirm this is related to an external tool, and isn't something that users have configured themselves...

@shiftkey shiftkey changed the title Vs2017 [VisualStudio] add Logs folder Aug 7, 2019
@paulsmithkc
Copy link
Contributor Author

@paulsmithkc paulsmithkc commented Aug 13, 2019

When using nlog, both "Log" and "Logs" (plus lowercase versions) depending on which tutorial/textbook you follow.

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 20, 2019

@paulsmithkc thanks!

@shiftkey shiftkey merged commit 26c3d84 into github:master Sep 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tokuhira added a commit to tokuhira/gitignore that referenced this pull request Dec 16, 2019
* Adding ignore rule for temporary office files.

* Adding Logs folder to ignore file.

* Revert "Adding ignore rule for temporary office files."

This reverts commit f6f191b.
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
* Adding ignore rule for temporary office files.

* Adding Logs folder to ignore file.

* Revert "Adding ignore rule for temporary office files."

This reverts commit f6f191b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants