[Swift] Added DS_Store and GoogleService-Info.plist #3137
Closed
Conversation
The DS_Store file isn't necessary to the purpose of most repositories so I remove it. Also, best practices would be to remove sensitive information from source control. Google Service Accounts are often used by iOS engineers as well as Vapor and Kitura engineers building on GCP/Firebase so I remove them from source control as a rule too.
|
See the global macOS gitignore for As for the plist:
Related: #2923 |
shiftkey
changed the title
|
@shiftkey no reply from the author, so I suggest that we close the pull request now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The DS_Store file isn't necessary to the purpose of most repositories so I remove it. Also, best practices would be to remove sensitive information from source control. Google Service Accounts are often used by iOS engineers as well as Vapor and Kitura engineers building on GCP/Firebase so I remove them from source control as a rule too.
Reasons for making this change:
I wanted to be able to use the swift.gitignore file from GitHub out of the box. I have to make these changes every time.
Links to documentation supporting these rule changes:
Wait what?
If this is a new template: