Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Ignore coverage annotations reports #3131

Merged
merged 1 commit into from Sep 20, 2019
Merged

Conversation

@thedrow
Copy link
Contributor

@thedrow thedrow commented Jul 23, 2019

Reasons for making this change:

There's no need to include these reports in the repository

**Links to documentation supporting these rule changes:

**https://coverage.readthedocs.io/en/coverage-4.2/cmd.html#text-annotation

If this is a new template:

N/A

@@ -47,6 +47,7 @@ htmlcov/
nosetests.xml
coverage.xml
*.cover
*.py,cover

This comment has been minimized.

@shiftkey

shiftkey Jul 23, 2019
Member

@thedrow is this the right extension? The , here seems like it'd be a huge problem on Windows, and I can't seem to find a mention of this in the documentation you linked to.

This comment has been minimized.

@thedrow

thedrow Jul 24, 2019
Author Contributor

That's the extension coverage generates.
Try it yourself.

Here's the code that says so BTW: https://github.com/nedbat/coveragepy/blob/502ecfc1767480ceefd0745d258a945163b61024/coverage/annotate.py#L21

This comment has been minimized.

@shiftkey

shiftkey Jul 24, 2019
Member

TIL: this actually works

@shiftkey shiftkey changed the title Ignore Python coverage annotations reports. [Python] Ignore coverage annotations reports Aug 7, 2019
@shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 20, 2019

@thedrow thanks!

@shiftkey shiftkey merged commit 3b445eb into github:master Sep 20, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AdamGleave AdamGleave mentioned this pull request Nov 19, 2019
4 of 4 tasks complete
tokuhira added a commit to tokuhira/gitignore that referenced this pull request Dec 16, 2019
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants