Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: potential redos #4221

Closed
aladdin-add opened this issue Aug 23, 2019 · 2 comments
Closed

security: potential redos #4221

aladdin-add opened this issue Aug 23, 2019 · 2 comments

Comments

@aladdin-add
Copy link
Contributor

stylelint/lib/rules/max-line-length/index.js

Lines 13 to 14 in f8d7865

/url\(\s*((.|[\t\v])*[^\s])\s*\)/gi, // allow tab, whitespace in url content
/@import\s+(['"](.|[\t\v])*['"])/gi

please do not use this kind of regex -- it can cause potential redos!
refs: https://en.wikipedia.org/wiki/ReDoS

btw, is there a better way to report security issues?(I don't think it's good to use GitHub for filing security issues.)
@hudochenkov
Copy link
Member

Thank you! We have a fix #4213.

is there a better way to report security issues?

You can email to one of maintainers. I have email in my profile.

@vankop vankop mentioned this issue Aug 23, 2019
Merged
@aladdin-add
Copy link
Contributor Author

closing, as it has been fixed by #4213

@pgs-gmartowski pgs-gmartowski mentioned this issue Aug 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hudochenkov @aladdin-add