Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake sure live docs have a '.html' extension #166
Merged
Conversation
ioncore/ioncore_misc.lua
Outdated
| @@ -99,7 +99,7 @@ function ioncore.tagged_attach(reg, param) | |||
| end | |||
|
|
|||
| function ioncore.show_live_docs(frame) | |||
| local filename = os.tmpname() | |||
| local filename = os.tmpname() .. ".html" | |||
This comment has been minimized.
This comment has been minimized.
wilhelmy
Aug 6, 2019
Collaborator
A problem here is that at least with Lua 5.3, os.tmpname() also creates the file instead of just returning a unique name (I guess because otherwise it can't be guaranteed that the filename is unique).
This comment has been minimized.
This comment has been minimized.
knixeur
Aug 6, 2019
Collaborator
It actually depends on the OS implementation. The alternative is to include posix Lua module but that would add a requirement just for this. I think 2 temp files won't hurt very much, it's not a functionality that will be run that often I think
This comment has been minimized.
This comment has been minimized.
wilhelmy
Aug 6, 2019
•
Collaborator
I propose using local filename = ioncore.tempdir().."keyboard.html" from my upcoming pull request.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
raboof commentedAug 6, 2019
Not needed for firefox at least, but neater