Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd benchmark to compare strict vs streamed response types #2644
Conversation
|
Test PASSed. |
|
Neat benchmark, was that |
| @@ -373,7 +373,7 @@ private[http] object HttpServerBluePrint { | |||
| val shape = new BidiShape(requestParsingIn, requestPrepOut, httpResponseIn, responseCtxOut) | |||
|
|
|||
| def createLogic(effectiveAttributes: Attributes) = new GraphStageLogic(shape) { | |||
| val pullHttpResponseIn = () => pull(httpResponseIn) | |||
| val pullHttpResponseIn = () => tryPull(httpResponseIn) | |||
raboof
Aug 16, 2019
Member
Was this intended/needed?
Was this intended/needed?
jrudolph
Aug 20, 2019
Author
Member
It's needed. It failed for the benchmark which doesn't use the full pipeline and probably triggers different race conditions on closing.
It's needed. It failed for the benchmark which doesn't use the full pipeline and probably triggers different race conditions on closing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently, it seems streamed response are ~1 order of magnitude slower at least. I guess some of that is somewhat expected as streaming is a memory optimization and not a performance optimization. Might still make sense to optimize if there are any low-hanging fruit. Also the benchmark will be used to look out for regressions.