Skip to content

/ akka-http

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance regression introduced in #2627 #2643

Merged
merged 2 commits into from Aug 14, 2019
Merged

Fix performance regression introduced in #2627 #2643

merged 2 commits into from Aug 14, 2019

Conversation

@jrudolph
Copy link
Member

@jrudolph jrudolph commented Aug 14, 2019 •
edited

Refs #2642.
jrudolph added 2 commits Aug 14, 2019
@jrudolph
Benchmark improvements
Verified
This commit was signed with a verified signature.
jrudolph Johannes Rudolph
GPG key ID: 52AF1C9ABD77E6E5 Learn about signing commits
7fcaf12
@jrudolph
Fix performance regression introduced in f47a646, refs #2642
Verified
This commit was signed with a verified signature.
jrudolph Johannes Rudolph
GPG key ID: 52AF1C9ABD77E6E5 Learn about signing commits
Loading status checks…
294eced
@jrudolph jrudolph requested a review from raboof Aug 14, 2019
@akka-ci akka-ci added validating tested and removed validating labels Aug 14, 2019
@akka-ci
Copy link

@akka-ci akka-ci commented Aug 14, 2019

Test PASSed.
@raboof
raboof approved these changes Aug 14, 2019
View changes
Copy link
Member

@raboof raboof left a comment

Definitely an improvement. Did you benchmark with non-strict requests?
@jrudolph
Copy link
Member Author

@jrudolph jrudolph commented Aug 14, 2019

Did you benchmark with non-strict requests?

No we currently don't do benchmarks with non-strict requests/responses but they are probably much slower anyway.
@jrudolph jrudolph merged commit f58f9c8 into akka:master Aug 14, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4165 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the jrudolph:jr/fix-performance-regression branch Aug 14, 2019
@jrudolph jrudolph mentioned this pull request Aug 14, 2019
Closed
@jrudolph
Copy link
Member Author

@jrudolph jrudolph commented Aug 14, 2019

Created #2644 to start tracking performance of streamed entity responses as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jrudolph @akka-ci @raboof
You can’t perform that action at this time.