Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
insert: globbing capability docstring correction (Cylc-8) #3296
Conversation
|
All good except for the help text content, as per comments in the 7.8.x PR. #3295 (comment) |
sadielbartholomew
force-pushed the
sadielbartholomew:insert-help-remove-globbing-ref-8
branch
from
ab7b19e
to
4e991f2
|
Feedback should now be addressed in a squashed commit, as for #3295, where the resulting |
|
Good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
These changes close #3284 (for
master/Cylc-8). Note I am applying a different approach for the equivalent PR to 7 & 8, adding the necessary text directly into theinsertdocstring for 7 since the version is soon to be dormant, but creating an alternative option-parser-level pattern matching text section here for 8 where something reusable & more maintainable could well be useful for CLI or functionality changes that may come in future.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.--helptext extraction script).