Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ivy the default in Angular! #32219

Closed
wants to merge 2 commits into from
+151 −173

Conversation

@alxhub
Copy link
Contributor

commented Aug 20, 2019 •
edited

🍃

@googlebot googlebot added the cla: yes label Aug 20, 2019

@alxhub alxhub added the PR target: master-only label Aug 20, 2019

@alxhub alxhub force-pushed the alxhub:ivy/default branch 7 times, most recently from efd1c0a to b3ca554 Aug 20, 2019

@alxhub alxhub marked this pull request as ready for review Aug 20, 2019

@alxhub alxhub requested review from angular/docs-infra as code owners Aug 20, 2019

@kara
kara approved these changes Aug 20, 2019
View changes
Copy link
Contributor

left a comment

LGTM
@IgorMinar
IgorMinar approved these changes Aug 20, 2019
View changes
Copy link
Member

left a comment

lgtm but I wish you left a note why the tsc passthrough option was removed - I suspect that it's because we implemented it initially to make Ivy JIT testing easier but then realized that we don't need it and we should just use tsc proper instead. Can you please clarify? thanks!
@alxhub

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 20, 2019

@IgorMinar I've been focused on getting the tests in the repo fixed - I still need to go back and add proper commit messages. Doing that now!
alxhub added 2 commits Aug 20, 2019
@alxhub
refactor(ivy): remove the tsc passthrough option 
This option makes ngc behave as tsc, and was originally implemented before
ngtsc existed. It was designed so we could build JIT-only versions of
Angular packages to begin testing Ivy early, and is not used at all in our
current setup.
Loading status checks…
b752c92
@alxhub
feat: make the Ivy compiler the default for ngc 
This commit switches the default value of the enableIvy flag to true.
Applications that run ngc will now by default receive an Ivy build!

This does not affect the way Bazel builds in the Angular repo work, since
those are still switched based on the value of the --define=compile flag.
Additionally, projects using @angular/bazel still use View Engine builds
by default.

Since most of the Angular repo tests are still written against View Engine
(particularly because we still publish VE packages to NPM), this switch
also requires lots of `enableIvy: false` flags in tsconfigs throughout the
repo.

Congrats to the team for reaching this milestone!
Loading status checks…
6ba8dcb

@alxhub alxhub force-pushed the alxhub:ivy/default branch from b3ca554 to 6ba8dcb Aug 20, 2019

@AndrewKushnir AndrewKushnir added PR action: presubmit comp: ivy PR action: merge labels Aug 20, 2019

@ngbot ngbot bot added this to the needsTriage milestone Aug 20, 2019

@AndrewKushnir

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 20, 2019 •
edited

@alxhub alxhub added the PR action: merge-assistance label Aug 20, 2019

@alxhub

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 20, 2019

Caretaker: I restarted a flaky CI test (test_docs_examples_ivy), but just in case it flakes again I'm adding merge-assistance.

@AndrewKushnir AndrewKushnir removed the PR action: presubmit label Aug 20, 2019

@AndrewKushnir

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 20, 2019

FYI, Ivy and VE presubmits look normal.

@AndrewKushnir AndrewKushnir closed this in 2b64031 Aug 20, 2019

AndrewKushnir added a commit that referenced this pull request Aug 20, 2019
@alxhub @AndrewKushnir
feat: make the Ivy compiler the default for ngc (#32219) 
This commit switches the default value of the enableIvy flag to true.
Applications that run ngc will now by default receive an Ivy build!

This does not affect the way Bazel builds in the Angular repo work, since
those are still switched based on the value of the --define=compile flag.
Additionally, projects using @angular/bazel still use View Engine builds
by default.

Since most of the Angular repo tests are still written against View Engine
(particularly because we still publish VE packages to NPM), this switch
also requires lots of `enableIvy: false` flags in tsconfigs throughout the
repo.

Congrats to the team for reaching this milestone!

PR Close #32219
Loading status checks…
ec4381d
@alan-agius4 alan-agius4 referenced this pull request Aug 21, 2019
Closed
ngdevelop-tech added a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
@alxhub @ngdevelop-tech
refactor(ivy): remove the tsc passthrough option (angular#32219) 
This option makes ngc behave as tsc, and was originally implemented before
ngtsc existed. It was designed so we could build JIT-only versions of
Angular packages to begin testing Ivy early, and is not used at all in our
current setup.

PR Close angular#32219
90f795b
ngdevelop-tech added a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
@alxhub @ngdevelop-tech
feat: make the Ivy compiler the default for ngc (angular#32219) 
This commit switches the default value of the enableIvy flag to true.
Applications that run ngc will now by default receive an Ivy build!

This does not affect the way Bazel builds in the Angular repo work, since
those are still switched based on the value of the --define=compile flag.
Additionally, projects using @angular/bazel still use View Engine builds
by default.

Since most of the Angular repo tests are still written against View Engine
(particularly because we still publish VE packages to NPM), this switch
also requires lots of `enableIvy: false` flags in tsconfigs throughout the
repo.

Congrats to the team for reaching this milestone!

PR Close angular#32219
337e996
@alexeagle
alexeagle reviewed Aug 27, 2019
View changes
integration/bazel-schematics/disable-ivy.js
const fs = require('fs');
const configPath = 'demo/tsconfig.json';
const config = {
...JSON.parse(fs.readFileSync(configPath, 'utf8')),

This comment has been minimized.

Sign in to view
Copy link
@alexeagle

alexeagle Aug 27, 2019

Contributor

drive-by nit: I learned yesterday that there's no need to string-decode the buffer first, JSON.parse handles buffers just fine
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@alxhub @sabeersulaiman
refactor(ivy): remove the tsc passthrough option (angular#32219) 
This option makes ngc behave as tsc, and was originally implemented before
ngtsc existed. It was designed so we could build JIT-only versions of
Angular packages to begin testing Ivy early, and is not used at all in our
current setup.

PR Close angular#32219
fe25ac1
sabeersulaiman added a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@alxhub @sabeersulaiman
feat: make the Ivy compiler the default for ngc (angular#32219) 
This commit switches the default value of the enableIvy flag to true.
Applications that run ngc will now by default receive an Ivy build!

This does not affect the way Bazel builds in the Angular repo work, since
those are still switched based on the value of the --define=compile flag.
Additionally, projects using @angular/bazel still use View Engine builds
by default.

Since most of the Angular repo tests are still written against View Engine
(particularly because we still publish VE packages to NPM), this switch
also requires lots of `enableIvy: false` flags in tsconfigs throughout the
repo.

Congrats to the team for reaching this milestone!

PR Close angular#32219
d3fdd06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle

@IgorMinar IgorMinar

@kara kara

@angular/fw-compiler fw-compiler

@angular/fw-upgrade fw-upgrade

Assignees
No one assigned
Labels
PR action: merge PR action: merge-assistance PR target: master-only cla: yes comp: ivy
Projects
None yet
Milestone
  needsTriage
6 participants
@alxhub @AndrewKushnir @alexeagle @IgorMinar @kara @googlebot
You can’t perform that action at this time.