Using net.JoinHostPort to format host:port strings#782
Conversation
IPv6 based addrs shoul look like [host]:port instead of host:port
|
Thank you. This will unfortunately break a lot of things. Building the correct It is very unfortunate, indeed, but the change to |
|
Hi @mialinx, I see you keep pushing changes. Would you like to perhaps explain what you are doing? Like I wrote earlier, there's a LOT to change if we want to go ipv6 that it's difficult to even find where to begin with. |
|
Hi @shlomi-noach, Yep, I'm trying to find all suspicious places like using As far as I understood, there are two main points:
It's very likely that I missed somtheing :( What other difficulties do you see ? |
|
Your changes are thorough, indeed. What concerns me are all the places where we parse |
|
It seems that integration tests flap as they depened on map keys order: |
|
I completely dropped the ball on this PR. It'll take me time to re0review it. |
|
could you please take a look at this PR? |
|
We really really need this PR. Please take a look 🙏 |
|
I apologize for not giving this attention. I very much appreciate the contribution and your work. It'll take a while before I've fully reviewed this. I'll meanwhile send for production testing in staging environment. |
IPv6 based addrs shoul look like [host]:port instead of host:port
A Pull Request should be associated with an Issue.
Related issue: https://github.com/github/orchestrator/issues/0123456789
Description
This PR [briefly explain what is does]
gofmt(please avoidgoimports)./build.shgo test ./go/...