Ignore configuration file #3125
Open
+3
−0
Conversation
Database credentials and security keys should not be commited.
Triloworld
added a commit
to Triloworld/gitignore
that referenced
this pull request
Jan 7, 2020
Hello all and thanks to create great file. There is problem to find proper meaning of content for this file in this repo. My propose need review as I have different, more direct approach with fix expectation. 1. Header to know what rules are used and be apply to project after using template. Errors can be removed, updates won't be broken and clearly show why I using that file. Right now, any changes are confused. This file many people use many times. 2. Introduce link to Github where template is created. Like a template, this can be modified so no big deal. Used as link where to watch. For this pull request nobody will update their gitignore file just because that link don't preexist from copy & paste. I see that some files have it so suggestion welcome. 3. Core Files need to be *ignored* (clue from comment) but there was broken part: Solution apply and work (thx. @stkrzysiak) : https://github.com/github/gitignore/pull/3093/files/1115dec039582df7242acd588811357f76d610ce#diff-f2cf96854b528e9828c4ca34a4917e54 Otherwise, all root catalog was added ;/ If core file need to be *included*, then we need fix other parts as : - /wp-content/language - /wp-content/index.php (security bug when someone use apache listings) 4. Thanks @chougran github#3125 This is most important as gitignore provide solution to sensitive credentials. Comments appreciate :)
This was referenced Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Database credentials and security keys should not be commited.
Reasons for making this change:
The wp-config.php file should not be commited, otherwise sensitive credentials would be commited too.
Links to documentation supporting these rule changes:
https://wordpress.org/support/article/editing-wp-config-php/