google / vim-codefmt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added XMLLint capability for XML #93

Open

rupert160 wants to merge 1 commit into google:master from rupert160:master

rupert160 commented Mar 25, 2018

Second attempt to push XML rebased to ensure no original email


          added XMLLint capability for XML

d891037

googlebot added the cla: yes label

Contributor

fowles commented Mar 25, 2018

A basic test like https://github.com/google/vim-codefmt/blob/master/vroom/dartfmt.vroom would be very much appreciated

dbarnett requested changes

Contributor

dbarnett left a comment

Can you add it to the lists in the README and in autoload/codefmt.vim / generated help file?

Re tests, the quickfix logic is involved enough it should have at least one quick bit of vroom coverage, but if you wanted to pull that out for now and just let it print an error message, I'd be fine with adding the test file myself as a follow-up change so it's more convenient for you to get something merged.

autoload/codefmt/xmllint.vim

  
          let l:formatter = {

              \ 'name': 'xmllint',

              \ 'setup_instructions': 'Install xmllint. ' .

                  \ '(man xmllint).'}

dbarnett Feb 26, 2020 Contributor

"man xmllint" isn't too helpful as installation instructions. It'd only do anything if xmllint were already installed. Could you point to a website with info about how to install on various platforms?

reds3c reviewed

reds3c left a comment •

edited

``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.