Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore tmp and log directory #2999

Merged
merged 1 commit into from Mar 14, 2019
Merged

Conversation

@okuramasafumi
Copy link
Contributor

@okuramasafumi okuramasafumi commented Mar 14, 2019

Reasons for making this change:

Rails 5.2.2.1 requires tmp directory committed to git repository for CI to run successfully.

Links to documentation supporting these rule changes:

https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/

https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/
Rails `5.2.2.1` requires `tmp` directory committed to git repository for CI to run successfully.
@shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 14, 2019

@okuramasafumi Any links to StackOverflow discussions or other documentation about this change? The release announcement don't seem to mention this (unless I overlooked it).

@shiftkey shiftkey added the needs info label Mar 14, 2019
@okuramasafumi
Copy link
Contributor Author

@okuramasafumi okuramasafumi commented Mar 14, 2019

rails/rails@0187053
Above is the link to the commit to solve this particular problem.
As mentioned in this commit, newly generated Rails app doesn't ignore tmp directory.

@shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 14, 2019

@okuramasafumi thanks!

@shiftkey shiftkey merged commit 1a417fe into github:master Mar 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Kiku-Reise added a commit to Kiku-Reise/gitignore that referenced this pull request Apr 6, 2019
https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/
Rails `5.2.2.1` requires `tmp` directory committed to git repository for CI to run successfully.
Ortega-Dan added a commit to Ortega-Dan/gitignore that referenced this pull request Jun 26, 2019
https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/
Rails `5.2.2.1` requires `tmp` directory committed to git repository for CI to run successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants