Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-tidy to buildsystem checks #1060

Open
Vtec234 opened this issue Oct 19, 2018 · 0 comments
Open

Add clang-tidy to buildsystem checks #1060

Vtec234 opened this issue Oct 19, 2018 · 0 comments
Labels
buildsystem code quality good first issue just do it python
Projects
buildsystem code quality

Comments

@Vtec234
Copy link
Contributor

@Vtec234 Vtec234 commented Oct 19, 2018

clang-tidy can detect lots of C++ programming and style errors, so it would be worthwile to have it included in make check. To do so, a Python module invoking it should be added to buildsystem.codecompliance.
@TheJJ TheJJ added buildsystem python code quality good first issue just do it labels Oct 19, 2018
kev946 added a commit to kev946/openage that referenced this issue Oct 20, 2018
@kev946
Add clang-tidy to buildsystem checks
e20ec3f 
Fixes SFTtech#1060
@kev946 kev946 mentioned this issue Oct 20, 2018
Closed
simonsan pushed a commit to simonsan/openage that referenced this issue Jun 20, 2019
@kev946 @simonsan
Add clang-tidy to buildsystem checks
a85d6aa 
Fixes SFTtech#1060
@simonsan simonsan added this to todo in buildsystem via automation Sep 6, 2019
simonsan pushed a commit to simonsan/openage that referenced this issue Sep 24, 2019
@kev946 @simonsan
Add clang-tidy to buildsystem checks
8602827 
Fixes SFTtech#1060
simonsan added a commit to simonsan/openage that referenced this issue Sep 24, 2019
@simonsan
Fix clang-tidy error messages
1417a76 
Fixes SFTtech#1060
@simonsan simonsan mentioned this issue Sep 25, 2019
Closed
3 tasks
@simonsan simonsan moved this from todo to in progress in buildsystem Sep 26, 2019
@simonsan simonsan added this to To do in code quality via automation Oct 4, 2019
@simonsan simonsan moved this from To do to clang-tidy related in code quality Oct 4, 2019
simonsan pushed a commit to simonsan/openage that referenced this issue Oct 8, 2019
@kev946 @simonsan
Add clang-tidy to buildsystem checks
1eecd72 
Fixes SFTtech#1060
simonsan pushed a commit to simonsan/openage that referenced this issue May 1, 2020
@kev946 @simonsan
Add clang-tidy to buildsystem checks
2445228 
Fixes SFTtech#1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buildsystem code quality good first issue just do it python
Projects
buildsystem
  
in progress
code quality
  
clang-tidy related
Milestone
No milestone
2 participants
@TheJJ @Vtec234