Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thought: Update cloudflare provider to use cloudflares supported python library #301

Open
Moumoutaru opened this issue Nov 27, 2018 · 1 comment

Comments

@Moumoutaru
Copy link

@Moumoutaru Moumoutaru commented Nov 27, 2018

Instead of interacting with the API as we currently do, would it be at all possible or useful to instead use Cloudflares python library. I noticed we are testing this provider with Cloudflares library, why not utilize it for the actual provisioning as well?

@ross
Copy link
Contributor

@ross ross commented Dec 9, 2018

It's been long enough that I don't remember the details, but I generally take a look at the API of a provider as well as the python client library before picking a route. For things with a clean and simple API I've found that the client libraries tend to make things more complicated more often than not and I remember starting down the path of using them a time or two and ran into problems/bugs that lead me to drop to hitting the API directly. Don't remember if that included CloudFlare or not.

If there's a case to be made for (big) advantages to switching to the library and someone wants to take it on then I'd look a PR over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.