inspector: removing checking of non existent field in lib/inspector.js #27919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like sessionAttached doesn't exist and no more assigned anywhere
addaleax
approved these changes
May 26, 2019
eugeneo
approved these changes
May 26, 2019
Thank you! This is a left over from the dark times when only a single concurrent connection was allowed, no longer needed.
cjihrig
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
BridgeAR
approved these changes
May 29, 2019
|
@Keroosha thanks a lot for looking closely into this at the code & learn! Awesome job! |
|
Landed in c91a90b |
pull bot
pushed a commit
to SimenB/node
that referenced
this issue
May 29, 2019
Seems like sessionAttached doesn't exist and no more assigned anywhere PR-URL: nodejs#27919 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
added a commit
that referenced
this issue
May 31, 2019
Seems like sessionAttached doesn't exist and no more assigned anywhere PR-URL: #27919 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Seems like sessionAttached doesn't exist and no more assigned anywhere
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes