Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36763: Remove _PyCoreConfig.dll_path #13402

Merged
merged 1 commit into from May 18, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 18, 2019

@vstinner
Copy link
Member Author

vstinner commented May 18, 2019

According to @zooba, there is no benefit to configure dll_path:

The dll_path field of PyConfig says "Windows only". Does that meant the
struct doesn't have that field except in a Windows build? Or is it
ignored, instead? If it doesn't have that field at all, what #define can
be used to determine if the PyConfig struct will have it or not?

This field doesn't need to be here. It exists because it was used in
getpathp.c, and Victor's internal refactoring has kept it around through
all the field movement.

https://mail.python.org/pipermail/python-dev/2019-May/157451.html

I understood that it would allow to decide where Python looks for DLL. It seems like I misunderstood the purpose of this field. So let's remove it :-)

@vstinner vstinner merged commit 410759f into python:master May 18, 2019
@vstinner vstinner deleted the remove_dll_path branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants