Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: remove unused rollup.config.js files #28646
+1
−1,272
Conversation
devversion
added
comp: build & ci
PR target: master & patch
labels
Feb 11, 2019
devversion
assigned
alexeagle and
IgorMinar
Feb 11, 2019
devversion
requested a review
from angular/fw-dev-infra
as a
code owner
Feb 11, 2019
ngbot
bot
added this to the needsTriage milestone
Feb 11, 2019
googlebot
added
the
cla: yes
label
Feb 11, 2019
devversion
added
the
PR action: review
label
Feb 11, 2019
alexeagle
approved these changes
Feb 13, 2019
This comment has been minimized.
This comment has been minimized.
|
Um, wait, I don't think any of the |
This comment has been minimized.
This comment has been minimized.
|
Good point hmm. I will double-check that tomorrow. |
IgorMinar
added
PR action: merge
PR action: cleanup
and removed
PR action: review
PR action: merge
labels
Feb 13, 2019
This comment has been minimized.
This comment has been minimized.
|
@devversion please apply the merge label when you are ready - it seems that you want to check on the config before merging. |
devversion
force-pushed the
devversion:build/fix-rollup-config-tslint-rule-windows
branch
from
8b63223
to
e590135
Feb 13, 2019
devversion
requested review from
IgorMinar
and
angular/fw-animations
as
code owners
Feb 13, 2019
devversion
requested a review
from angular/tools-language-service
as a
code owner
Feb 13, 2019
devversion
changed the title
build: fix rollup config tslint rule not working on windows
build: remove unused rollup.config.js files
Feb 13, 2019
devversion
added
PR action: review
and removed
PR action: cleanup
labels
Feb 13, 2019
This comment has been minimized.
This comment has been minimized.
|
@IgorMinar @alexeagle I've updated this PR. We should be able to safely remove the can you please have another look? (I need a global approval/or review from all packages |
devversion
added
PR action: merge
and removed
PR action: review
labels
Feb 14, 2019
added a commit
that referenced
this pull request
Feb 14, 2019
mhevery
closed this
in
7cbc36f
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
devversion commentedFeb 11, 2019
•
edited
Since we build and publish the individual packages using Bazel and
build.shhas been removed, we can safely remove therollup.config.jsfiles which are no longer needed because the
ng_packagebazel ruleautomatically handles the rollup settings and globals.