fix(bazel): transitive npm deps in ng_module #30065

gregmagolan · 2019-04-23T17:54:08Z

BREAKING CHANGE: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12.

Equivalent change to ng_module that was made to ts_library in bazelbuild/rules_nodejs#675.

This fixes the issue reported by @mattem and reproducible here https://github.com/mattem/ng_transitive_deps_eg

If a transitive npm dep such as @npm//moment-timezone is missing which is not used directly by any files compiled in an ng_module but is used transitively by a dep like //service,

ng_module(
    name = "component",
    srcs = glob(["*.ts"]),
    deps = [
        "//service",
        "@npm//@angular/core",
        "@npm//@angular/common",
        # "@npm//moment-timezone",
    ],
    visibility = ["//:__subpackages__"],
    tsconfig = "//:tsconfig",
)

this can lead to the isSkipSelf error which is not helpful at all:

ERROR: /Users/greg/google/gregmagolan/ng_transitive_deps_eg/component/BUILD:3:1: Compiling Angular templates (ngc) //component:component failed (Exit 1) ngc-wrapped__bin failed: error executing command bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin '--node_options=--expose-gc' '--node_options=--stack-trace-limit=100' '--node_options=--max-old-space-size=2048' ... (remaining 1 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
: TypeError: Cannot read property 'isSkipSelf' of null
    at ProviderElementContext._getDependency (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20171:22)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20116:64
    at Array.map (<anonymous>)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20116:30
    at Array.map (<anonymous>)
    at ProviderElementContext._getOrCreateLocalProvider (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20094:67)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:19992:27
    at Array.forEach (<anonymous>)
    at new ProviderElementContext (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:19989:53)
    at TemplateParseVisitor.visitElement (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21476:35)
    at Element.visit (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10673:80)
    at visit (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10689:41)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10691:29
    at Array.forEach (<anonymous>)
    at visitAll$1 (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10690:15)
    at TemplateParser.tryParseHtml (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21329:26)
    at TemplateParser.tryParse (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21310:25)
    at TemplateParser.parse (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21288:31)
    at AotCompiler._parseTemplate (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24803:47)
    at AotCompiler._createTypeCheckBlock (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24550:27)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24518:31
    at Array.forEach (<anonymous>)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24512:53
    at Array.forEach (<anonymous>)
    at AotCompiler._createNgFactoryStub (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24491:28)
    at AotCompiler.emitTypeCheckStub (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24459:22)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:655:54
    at Array.forEach (<anonymous>)
    at AngularCompilerProgram._updateProgramWithTypeCheckStubs (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:649:41)
    at AngularCompilerProgram.initSync (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:582:22)
    at AngularCompilerProgram.get [as tsProgram] (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:514:26)
    at AngularCompilerProgram.getTsProgram (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:147:83)
    at gatherDiagnosticsForInputsOnly (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:408:37)
    at gatherDiagnostics (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:340:46)
    at Object.performCompilation (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/perform_compile.js:213:72)
    at compile (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:342:57)
    at runOneBuild (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:116:33)
    at main (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:39:20)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:432:28
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:10:17
    at Object.<anonymous> (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:16:3)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Object.<anonymous> (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin_bin_loader.js:489:24)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)
    at startup (internal/bootstrap/node.js:285:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)

INFO: Elapsed time: 76.755s, Critical Path: 25.71s
INFO: 1 process: 1 darwin-sandbox.
FAILED: Build did NOT complete successfully

BREAKING CHANGE: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12

benlesh · 2019-04-23T22:06:35Z

@alexeagle This PR is bombing before TAP even starts in google3: https://critique.corp.google.com/#review/244931913

AndrewKushnir · 2019-04-24T20:54:18Z

Removing "release blocker" label from this PR after a quick chat with Alex Eagle.

BREAKING CHANGE: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12 PR Close angular#30065

angular-automatic-lock-bot · 2019-09-15T00:23:18Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gregmagolan requested a review from alexeagle Apr 23, 2019

gregmagolan requested a review from as a code owner Apr 23, 2019

googlebot added the cla: yes label Apr 23, 2019

gregmagolan added the comp: bazel label Apr 23, 2019

ngbot bot added this to the needsTriage milestone Apr 23, 2019

gregmagolan added the target: major label Apr 23, 2019

fix(bazel): transitive npm deps in ng_module

dac5fca

BREAKING CHANGE: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12

gregmagolan force-pushed the ng-module-transitive-npm-deps branch from 8fcfe41 to dac5fca Compare Apr 23, 2019

alexeagle approved these changes Apr 23, 2019

View changes

alexeagle added hotlist: release-blocker action: merge labels Apr 23, 2019

benlesh added the action: presubmit label Apr 23, 2019

benlesh added the action: cleanup label Apr 23, 2019

IgorMinar removed this from the needsTriage milestone Apr 24, 2019

IgorMinar added this to the version 8 milestone Apr 24, 2019

AndrewKushnir removed the hotlist: release-blocker label Apr 24, 2019

alexeagle added action: merge-assistance and removed action: cleanup labels Apr 25, 2019

AndrewKushnir removed the action: presubmit label Apr 25, 2019

AndrewKushnir closed this in angular/angular@61365a9 Apr 25, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this issue May 21, 2019

fix(bazel): transitive npm deps in ng_module (angular#30065)

e7ad876

BREAKING CHANGE: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12 PR Close angular#30065

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

angular / angular Public

fix(bazel): transitive npm deps in ng_module #30065

fix(bazel): transitive npm deps in ng_module #30065

gregmagolan commented Apr 23, 2019 •

edited

benlesh commented Apr 23, 2019

AndrewKushnir commented Apr 24, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

angular / angular Public

fix(bazel): transitive npm deps in ng_module #30065

fix(bazel): transitive npm deps in ng_module #30065

Conversation

gregmagolan commented Apr 23, 2019 • edited

benlesh commented Apr 23, 2019

AndrewKushnir commented Apr 24, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

gregmagolan commented Apr 23, 2019 •

edited