Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 31 million developers.
Sign up
Build cross-platform desktop apps with JavaScript, HTML, and CSS
The hackable text editor
1,361 contributions in the last year
Contribution activity
March 2019
Created a pull request in electron/electron that received 4 comments
fix: check the result when calling js function
Description of Change When a JS function returns undefined, the returned v8::MaybeLocal in C++ would be empty, and calling ToLocalChecked() without…
+26
−18
•
4
comments
- refactor: Enable network service (Part 1)
- fix: validate sender for replies in ipcMainInternalUtils.invokeInWebContents()
- feat: add <webview>.getWebContentsId()
- feat: only allow bundled preload scripts
- feat: promisify dialog.showCertificateTrustDialog()
- feat: promisify session.getBlobData()
- feat: promisify dialog.showMessageBox()
- feat: Add content script world isolation
- chore: add description to accelerator.patch
- chore: add static promise resolution helpers
- feat: promisify dialog.showSaveDialog()
- feat: promisify dialog.showOpenDialog()
- fix: make StreamSubscriber ref counted
- [wip] feat: make remote.getGuestWebContents() public