Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[wip] Allow comment margin to appear on editable diff view #2239
Conversation
jcansdale
changed the title
jcansdale
changed the title
|
Comments on editable files are no longer a thing (see #2408). Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What this PR does
Previously the comment margin would only appear on pull request files that are open in a "full" editor window. This pull request allows the comment margin to also appear on editable diff windows.
How to test
Check
Show PR comments in editor marginfeature flag optionOpen a pull request and checkout its branch
Right-click on a pull request file and
View Changes in SolutionToggle the check-box in the margin
Click comment glyph in margin to view comment
Observations
This functionality wasn't ready for prime time and has remained behind a feature flag.
What didn't work well
What worked well
Possible future work