Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Only show `Sign in with your browser` option for github.com #2201
Conversation
|
Hmm, I'm not sure this really adds much: my gaze is still going straight to the user/pass textboxes as that's what I expect from a login dialog. What about: when opening the dialog, show a button saying "Sign in with your browser", and below it a smaller link saying "Sign in with username and password" and only when you click that button the UI changes to display the user/pass boxes? |
That sounds good. What to you think @donokuda ? Could you pick up where I left off on this PR? |
Signing with with username/password is going away, see: https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/
jcansdale
changed the title
|
Obsoleted by #2469 |
In future only the
Sign in with your browser option will work(see here). We need to remove the user/pass/2FA UI.Sign in with browser is by far the easiest authentication method and should be encouraged where possible. In order to do this, we're placing it first in the list of login options (see #2194).
What this PR does
Sign in with browseroption above other optionsWhat this PR doesn't do
We considered only showing the
Sign in with browseroption when available. We decided not to do this for the following reasons.There might be times where it is necessary to log in using a token (e.g to push a GitHub Action)theworkflowscope is now being requested, see #2462How to test
The GitHub and GitHub Enterprise logins should look like this:
GitHub
GitHub Enterprise
