Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Try really hard to avoid deadlocking GetService calls #1597
Conversation
`new ShellSettingsManager` in the PackageSettings constructor calls GetService, which might be a potential deadlock situation. Also, to avoid calls to GetService that might deadlock, cache the services we create in GitHubServiceProvider so that it returns cached instances immediately and bypasses GetService.
|
Too many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
new ShellSettingsManagerin the PackageSettings constructor calls GetService, which might be a potential deadlock situation. Also, to avoid calls to GetService that might deadlock, cache the services we create in GitHubServiceProvider so that it returns cached instances immediately and bypasses GetService.I also fixed some other calls around the code, particularly direct calls to
ExportProvider(GitHubServiceProvider.TryGetServicedoes that for us)