Skip to content
This repository has been archived by the owner. It is now read-only.

fixing required not being present in inputs for custom credentials #690

Merged
merged 2 commits into from Apr 1, 2019

Conversation

@jainnikhil30
Copy link
Contributor

@jainnikhil30 jainnikhil30 commented Apr 1, 2019

Fixes #641

@coveralls
Copy link

@coveralls coveralls commented Apr 1, 2019

Coverage Status

Coverage remained the same at 64.436% when pulling 1e377c4 on jainnikhil30:master into f210a85 on ansible:master.

Copy link
Member

@AlanCoding AlanCoding left a comment

wait, sorry, I might have read wrong earlier.

I can't see why you removed the in operation. It looks like field['id'] in should not have been removed

@jainnikhil30
Copy link
Contributor Author

@jainnikhil30 jainnikhil30 commented Apr 1, 2019

@AlanCoding

Apologies for the oversight. My bad. Changed that.
Thanks for your review.

@jainnikhil30 jainnikhil30 requested a review from AlanCoding Apr 1, 2019
@AlanCoding AlanCoding merged commit 9a571f6 into ansible:master Apr 1, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 64.436%
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.